pkg/cli: Drop command tree snapshot test#473
Queued
timflannagan wants to merge 1 commit intomainfrom
Queued
Conversation
The command tree test froze the full top-level CLI surface and a few subcommand counts without encoding a meaningful compatibility contract. That made routine CLI evolution require brittle test updates while root behavior continues to live in root_test.go. Signed-off-by: timflannagan <timflannagan@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the generated-style Cobra command tree snapshot test from pkg/cli, reducing brittleness for routine CLI surface changes while keeping functional root behavior covered by pkg/cli/root_test.go.
Changes:
- Delete
pkg/cli/commands_test.go, which asserted a full top-level command list and some command metadata/flag presence checks. - Rely on existing targeted root behavior tests in
pkg/cli/root_test.gorather than a command-tree snapshot contract.
xytian315
approved these changes
May 4, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Any commits made after this event will not be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the generated-style
pkg/cli/commands_test.gocoverage test. The testsnapshotted the full top-level Cobra command list and a few weak command
metadata assertions, which made normal CLI changes brittle without adding a
meaningful compatibility contract. Root command behavior remains covered in
pkg/cli/root_test.go.Change Type
/kind cleanup
Changelog
Additional Notes
Verified with
go test ./pkg/cli.