Skip to content

ci: collect + upload coverage to Codecov #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nficano merged 1 commit into from
May 25, 2026
+14 −1
Merged

ci: collect + upload coverage to Codecov #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,16 +75,29 @@ jobs:
- name: Build
run: dotnet build ARCP.slnx --configuration Release --no-restore

- name: Test (unit)
- name: Test (unit, with coverage)
run: >
dotnet test tests/Arcp.UnitTests/Arcp.UnitTests.fsproj
--configuration Release
--no-build
--verbosity normal
--collect:"XPlat Code Coverage"
--logger "trx;LogFileName=unit-tests.trx"
--logger "console;verbosity=normal"
--results-directory ${{ github.workspace }}/TestResults

# coverlet.collector writes one coverage.cobertura.xml per test
# project under TestResults/<guid>/. Non-blocking so a Codecov
# outage cannot break CI.
- name: Upload coverage to Codecov
# codecov/codecov-action v6.0.1
uses: codecov/codecov-action@e79a6962e0d4c0c17b229090214935d2e33f8354 # v6.0.1
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot May 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify codecov-action SHA matches v6.0.1 and check for latest releases

# Check if the SHA matches the v6.0.1 tag
echo "=== Checking if SHA e79a6962e0d4c0c17b229090214935d2e33f8354 matches v6.0.1 ==="
gh api repos/codecov/codecov-action/git/ref/tags/v6.0.1 --jq '.object.sha'

# List recent releases to see if newer versions exist
echo -e "\n=== Recent releases of codecov/codecov-action ==="
gh api repos/codecov/codecov-action/releases --jq '.[:5] | .[] | "\(.tag_name) - \(.published_at) - \(.name)"'

# Check what commit the SHA points to
echo -e "\n=== Commit details for SHA e79a6962e0d4c0c17b229090214935d2e33f8354 ==="
gh api repos/codecov/codecov-action/commits/e79a6962e0d4c0c17b229090214935d2e33f8354 --jq '{sha: .sha, message: .commit.message, date: .commit.committer.date}'

Repository: agentruntimecontrolprotocol/fsharp-sdk

Length of output: 645

Fix the mismatched v6.0.1 version annotation for codecov/codecov-action.

  • .github/workflows/test.yml:94 pins codecov/codecov-action@e79a6962e0d4c0c17b229090214935d2e33f8354, but the v6.0.1 tag points to cddd853df119a48c5be31a973f8cd97e12e35e16, so # v6.0.1 is inaccurate—either pin the v6.0.1 tag commit or correct/remove the version comment.
  • No newer release than v6.0.1 appeared in the recent releases returned.
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/test.yml at line 94, The workflow comment for the Codecov
action is incorrect: the action is pinned to commit
e79a6962e0d4c0c17b229090214935d2e33f8354 but annotated as “# v6.0.1”; fix this
by either changing the pinned reference to the commit that actually corresponds
to tag v6.0.1 (cddd853df119a48c5be31a973f8cd97e12e35e16) or by removing/updating
the trailing version comment to match the pinned commit (i.e., update the
comment on the uses:
codecov/codecov-action@e79a6962e0d4c0c17b229090214935d2e33f8354 line to the
correct tag/commit or change the pin to
`@cddd853df119a48c5be31a973f8cd97e12e35e16`).

with:
fail_ci_if_error: false
flags: unittests
directory: ${{ github.workspace }}/TestResults
token: ${{ secrets.CODECOV_TOKEN }}

- name: Upload test results
if: failure()
uses: actions/upload-artifact@v7
Expand Down