-
Notifications
You must be signed in to change notification settings - Fork 7
Exclude the .jj folder automatically #434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughAdds two default ignore patterns for .jj directories in internal/ignore/rules.go by appending "/.jj//*" and "/.jj" to AddDefaults after the existing "/.git" rule. No other logic, error handling, or exported/public declarations are changed. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
internal/ignore/rules.go (1)
68-69: Optional: add a brief comment to clarify that .jj is Jujutsu’s VCS metadata.A tiny note will help future maintainers unfamiliar with jj understand why this is ignored by default.
r.parseRule("**/.git") +// ignore Jujutsu (jj) VCS metadata directories r.parseRule("**/.jj/**/*") r.parseRule("**/.jj")
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
internal/ignore/rules.go(1 hunks)
🔇 Additional comments (1)
internal/ignore/rules.go (1)
68-69: Good call adding .jj ignore patterns; matches .git handling and covers dir + contents.These two patterns mirror the existing .git rules and ensure both the .jj directory itself and everything under it are ignored with doublestar semantics. Placement directly after the .git entries preserves intent and order. No functional concerns.
Summary by CodeRabbit