Skip to content

Conversation

@jhaynie
Copy link
Member

@jhaynie jhaynie commented Aug 18, 2025

Summary by CodeRabbit

  • New Features
    • Added default ignore support for .jj directories and their contents. These folders will no longer appear in listings or operations that respect ignore rules.
  • Chores
    • Updated default ignore configuration to include .jj alongside existing ignores.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 18, 2025

Walkthrough

Adds two default ignore patterns for .jj directories in internal/ignore/rules.go by appending "/.jj//*" and "/.jj" to AddDefaults after the existing "/.git" rule. No other logic, error handling, or exported/public declarations are changed.

Changes

Cohort / File(s) Summary of changes
Ignore defaults update
internal/ignore/rules.go
Appends two new default ignore patterns: "/.jj//*" and "/.jj" within AddDefaults, following the existing "/.git" rule. No other modifications.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

A whisk of code, a hop in trees,
We hush the hidden .jj seas.
With patterns tucked where ignores sit,
We bound past noise—no peeking bit.
Carrot-typed, commit by commit—
A tidy burrow, neat and lit. 🥕🐇

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch exclude-jj

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
internal/ignore/rules.go (1)

68-69: Optional: add a brief comment to clarify that .jj is Jujutsu’s VCS metadata.

A tiny note will help future maintainers unfamiliar with jj understand why this is ignored by default.

 r.parseRule("**/.git")
+// ignore Jujutsu (jj) VCS metadata directories
 r.parseRule("**/.jj/**/*")
 r.parseRule("**/.jj")
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between d7615cc and ecfc05e.

📒 Files selected for processing (1)
  • internal/ignore/rules.go (1 hunks)
🔇 Additional comments (1)
internal/ignore/rules.go (1)

68-69: Good call adding .jj ignore patterns; matches .git handling and covers dir + contents.

These two patterns mirror the existing .git rules and ensure both the .jj directory itself and everything under it are ignored with doublestar semantics. Placement directly after the .git entries preserves intent and order. No functional concerns.

@jhaynie jhaynie merged commit de9b926 into main Aug 18, 2025
14 checks passed
@jhaynie jhaynie deleted the exclude-jj branch August 18, 2025 17:22
@devin-ai-integration devin-ai-integration bot mentioned this pull request Aug 18, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants