Skip to content

[AGENT-628] prevent local development env files from syncing to production #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pec1985 merged 2 commits into from
Sep 1, 2025
Merged

[AGENT-628] prevent local development env files from syncing to production #440

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bc9efc
fix: prevent local development env files from syncing to production
pec1985 Sep 1, 2025
1c1d569
Fix messaging around env vars syncing with production
pec1985 Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 18 additions & 7 deletions internal/envutil/envutil.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,11 @@ func ProcessEnvFiles(ctx context.Context, logger logger.Logger, dir string, thep
errsystem.WithContextMessage("Error parsing .env file")).ShowErrorAndExit()
}

projectData = HandleMissingProjectEnvs(ctx, logger, le, projectData, theproject, apiUrl, token, force)
// Only sync env vars to production when not in local development mode
// Local development files (.env.development, .env.local, etc.) should never be synced to production
if !isLocalDev {
projectData = HandleMissingProjectEnvs(ctx, logger, le, projectData, theproject, apiUrl, token, force, envfilename)
}
envFile.Env = le
return envFile, projectData
}
Expand Down Expand Up @@ -149,7 +153,7 @@ func HandleMissingTemplateEnvs(logger logger.Logger, dir, envfilename string, le
}

// HandleMissingProjectEnvs handles missing envs in project
func HandleMissingProjectEnvs(ctx context.Context, logger logger.Logger, le []env.EnvLineComment, projectData *project.ProjectData, theproject *project.Project, apiUrl, token string, force bool) *project.ProjectData {
func HandleMissingProjectEnvs(ctx context.Context, logger logger.Logger, le []env.EnvLineComment, projectData *project.ProjectData, theproject *project.Project, apiUrl, token string, force bool, envFilename string) *project.ProjectData {

if projectData == nil {
projectData = &project.ProjectData{}
Expand All @@ -171,28 +175,35 @@ func HandleMissingProjectEnvs(ctx context.Context, logger logger.Logger, le []en
if !force {
var title string
var suffix string
var question string
envFileDisplayName := tui.Bold(filepath.Base(envFilename))

switch {
case len(keyvalue) < 3 && len(keyvalue) > 1:
suffix = "it"
suffix = "them"
var colorized []string
for key := range keyvalue {
colorized = append(colorized, tui.Bold(key))
}
title = fmt.Sprintf("The environment variables %s from %s are not been set in the project.", strings.Join(colorized, ", "), tui.Bold(".env"))
title = fmt.Sprintf("The environment variables %s from %s are not set in your cloud project.", strings.Join(colorized, ", "), envFileDisplayName)
question = fmt.Sprintf("Would you like to sync %s to your cloud project now?", suffix)
case len(keyvalue) == 1:
var key string
for _key := range keyvalue {
key = _key
break
}
suffix = "it"
title = fmt.Sprintf("The environment variable %s from %s has not been set in the project.", tui.Bold(key), tui.Bold(".env"))
title = fmt.Sprintf("The environment variable %s from %s has not been set in your cloud project.", tui.Bold(key), envFileDisplayName)
question = fmt.Sprintf("Would you like to sync %s to your cloud project now?", suffix)
default:
suffix = "them"
title = fmt.Sprintf("There are %d environment variables from %s that are not set in the project.", len(keyvalue), tui.Bold(".env"))
title = fmt.Sprintf("There are %d environment variables from %s that are not set in your cloud project.", len(keyvalue), envFileDisplayName)
question = fmt.Sprintf("Would you like to sync %s to your cloud project now?", suffix)
}
fmt.Println(title)
force = tui.Ask(logger, "Would you like to set "+suffix+" now?", true)
fmt.Println(tui.Muted("(Choosing 'no' won't affect your local development - these variables will still work locally)"))
force = tui.Ask(logger, question, true)
}
if force {
for key, val := range keyvalue {
Expand Down
Loading