Skip to content

[AGENT-684] Check if zsh is installed before adding autocomplete in t… #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pec1985 merged 1 commit into from
Sep 24, 2025
Merged

[AGENT-684] Check if zsh is installed before adding autocomplete in t… #450

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,8 @@ install_completions() {
fi
fi

if [ -d "/usr/local/share/zsh/site-functions" ]; then
# Check if zsh is installed before attempting to install zsh completion
if command -v zsh >/dev/null 2>&1 && [ -d "/usr/local/share/zsh/site-functions" ]; then
ZSH_COMPLETION_DIR="/usr/local/share/zsh/site-functions"
if [ -w "$ZSH_COMPLETION_DIR" ]; then
ohai "Generating zsh completion script..."
Expand All @@ -394,6 +395,9 @@ install_completions() {
else
warn "No write permission to $ZSH_COMPLETION_DIR. Skipping zsh completion installation."
fi
elif ! command -v zsh >/dev/null 2>&1; then
# Only skip silently if zsh is not installed (avoid unnecessary warnings)
debug "Zsh not found, skipping zsh completion installation"
fi
fi

Expand All @@ -411,7 +415,8 @@ install_completions() {
fi
fi

if [ -d "/usr/share/zsh/vendor-completions" ]; then
# Check if zsh is installed before attempting to install zsh completion
if command -v zsh >/dev/null 2>&1 && [ -d "/usr/share/zsh/vendor-completions" ]; then
ZSH_COMPLETION_DIR="/usr/share/zsh/vendor-completions"
if [ -w "$ZSH_COMPLETION_DIR" ]; then
ohai "Generating zsh completion script..."
Expand All @@ -425,6 +430,9 @@ install_completions() {
echo " echo 'fpath=(~/.zsh/completion \$fpath)' >> ~/.zshrc"
echo " echo 'autoload -U compinit && compinit' >> ~/.zshrc"
fi
elif ! command -v zsh >/dev/null 2>&1; then
# Only skip silently if zsh is not installed (avoid unnecessary warnings)
debug "Zsh not found, skipping zsh completion installation"
fi
fi
fi
Expand Down
Loading