-
Notifications
You must be signed in to change notification settings - Fork 7
Changed up the function signature and add a couple features #460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
93c05d0
added new sig route 2
potofpie 19afb96
ts seems good onto js
potofpie c4f128d
js seems good now
potofpie d0a3953
everything seems to be working
potofpie 6d84c5a
stuff is working
potofpie a466164
stuff is working
potofpie 8133604
removed compile
potofpie 2e35b40
added route 2
potofpie bf4615f
remove unused file
potofpie a289f27
remove markdown
potofpie 8297282
made small change
potofpie 9b9088e
remove unused functions
potofpie 251a0b1
fix tests
potofpie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion | 🟠 Major
Rule vs implementation mismatch: always emit
systemandpromptfieldsThe generator currently omits missing fields, which reintroduces optional chaining. Update generator to always emit both with empty-string returns when absent. As per coding guidelines.
🤖 Prompt for AI Agents