Skip to content

Add breaking change check for 0.0.154 #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potofpie merged 2 commits into from
Oct 14, 2025
Merged

Add breaking change check for 0.0.154 #470

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
667d683
force the update
potofpie Oct 14, 2025
4d22dbb
force the update
potofpie Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions internal/bundler/upgrade.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,18 @@ type breakingChange struct {
}

var breakingChanges = []breakingChange{
{
Runtime: "bunjs",
Version: "<0.0.154",
Title: "🚫 JS SDK Update Required 🚫",
Message: "An internal change related to telemetry requires updating to the latest SDK version. There are no code changes required on your end.\n\nPlease run bun update @agentuity/sdk --latest and then re-run this command again.",
},
{
Runtime: "nodejs",
Version: "<0.0.154",
Title: "🚫 JS SDK Update Required 🚫",
Message: "An internal change related to telemetry requires updating to the latest SDK version. There are no code changes required on your end.\n\nPlease run npm upgrade @agentuity/sdk and then re-run this command again.",
},
Comment on lines +25 to +36
Copy link
Contributor

@coderabbitai coderabbitai bot Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Critical ordering issue: Place these entries after existing breaking changes.

The new <0.0.154 entries are positioned before older, more restrictive version constraints like <0.0.106 and <0.0.115. Since checkForBreakingChanges (line 231) stops at the first matching constraint, users on very old SDK versions (e.g., 0.0.100) will see only the telemetry update message and skip critical breaking changes that require code modifications (async AgentRequest signatures, API key environment variable changes, etc.). After updating to >=0.0.154, these older constraints will never trigger, leaving user code incompatible with the newer SDK.

Move these two entries to the end of the breakingChanges slice (after line 144, before the closing brace on line 145). This ensures users encounter breaking changes in chronological order, starting with the most restrictive (oldest) constraints first:

 var breakingChanges = []breakingChange{
-	{
-		Runtime: "bunjs",
-		Version: "<0.0.154",
-		Title:   "🚫 JS SDK Update Required 🚫",
-		Message: "An internal change related to telemetry requires updating to the latest SDK version. There are no code changes required on your end.\n\nPlease run bun update @agentuity/sdk --latest and then re-run this command again.",
-	},
-	{
-		Runtime: "nodejs",
-		Version: "<0.0.154",
-		Title:   "🚫 JS SDK Update Required 🚫",
-		Message: "An internal change related to telemetry requires updating to the latest SDK version. There are no code changes required on your end.\n\nPlease run npm upgrade @agentuity/sdk and then re-run this command again.",
-	},
 	{
 		Runtime: "bunjs",
 		Version: "<0.0.106",
 			return nil
 		},
 	},
+	{
+		Runtime: "bunjs",
+		Version: "<0.0.154",
+		Title:   "🚫 JS SDK Update Required 🚫",
+		Message: "An internal change related to telemetry requires updating to the latest SDK version. There are no code changes required on your end.\n\nPlease run bun update @agentuity/sdk --latest and then re-run this command again.",
+	},
+	{
+		Runtime: "nodejs",
+		Version: "<0.0.154",
+		Title:   "🚫 JS SDK Update Required 🚫",
+		Message: "An internal change related to telemetry requires updating to the latest SDK version. There are no code changes required on your end.\n\nPlease run npm upgrade @agentuity/sdk and then re-run this command again.",
+	},
 }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
{
Runtime: "bunjs",
Version: "<0.0.154",
Title: "🚫 JS SDK Update Required 🚫",
Message: "An internal change related to telemetry requires updating to the latest SDK version. There are no code changes required on your end.\n\nPlease run bun update @agentuity/sdk --latest and then re-run this command again.",
},
{
Runtime: "nodejs",
Version: "<0.0.154",
Title: "🚫 JS SDK Update Required 🚫",
Message: "An internal change related to telemetry requires updating to the latest SDK version. There are no code changes required on your end.\n\nPlease run npm upgrade @agentuity/sdk and then re-run this command again.",
},
@@ -25,8 +25,6 @@ var breakingChanges = []breakingChange{
- {
- Runtime: "bunjs",
- Version: "<0.0.154",
- Title: "🚫 JS SDK Update Required 🚫",
- Message: "An internal change related to telemetry requires updating to the latest SDK version. There are no code changes required on your end.\n\nPlease run bun update @agentuity/sdk --latest and then re-run this command again.",
- },
- {
- Runtime: "nodejs",
- Version: "<0.0.154",
- Title: "🚫 JS SDK Update Required 🚫",
- Message: "An internal change related to telemetry requires updating to the latest SDK version. There are no code changes required on your end.\n\nPlease run npm upgrade @agentuity/sdk and then re-run this command again.",
- },
@@ -144,6 +142,14 @@ var breakingChanges = []breakingChange{
},
},
{
Runtime: "bunjs",
Version: "<0.0.154",
Title: "🚫 JS SDK Update Required 🚫",
Message: "An internal change related to telemetry requires updating to the latest SDK version. There are no code changes required on your end.\n\nPlease run bun update @agentuity/sdk --latest and then re-run this command again.",
},
{
Runtime: "nodejs",
Version: "<0.0.154",
Title: "🚫 JS SDK Update Required 🚫",
Message: "An internal change related to telemetry requires updating to the latest SDK version. There are no code changes required on your end.\n\nPlease run npm upgrade @agentuity/sdk and then re-run this command again.",
},
}
🤖 Prompt for AI Agents 
In internal/bundler/upgrade.go around lines 25 to 36, the two entries for
Runtime "bunjs" and "nodejs" with Version "<0.0.154" must be moved from their
current position to the end of the breakingChanges slice: place them after line
144 and before the closing brace on line 145 so they appear after all existing
older/more restrictive constraints; when moving, preserve the exact entries and
punctuation, ensure the slice commas remain correct and run `go vet`/`gofmt` to
validate the file.

{
Runtime: "bunjs",
Version: "<0.0.106",
Expand Down
Loading