-
Notifications
You must be signed in to change notification settings - Fork 1
Fix vector delete API documentation to show single key deletion #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Update JavaScript SDK API reference to show delete(name, key) instead of delete(name, ...ids) - Update Python SDK API reference to show delete(name, key) instead of delete(name, *ids) - Fix JavaScript example to use single key deletion - Fix Python example to use single key deletion and improve clarity - Align documentation with actual SDK implementations that only support single key deletion The backend Catalyst API only supports single key deletion, so the SDKs were correctly implemented but the documentation was never updated to reflect this limitation. Co-Authored-By: jhaynie@agentuity.com <jhaynie@gmail.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Join our Discord community for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
docs | 0f5880b | Commit Preview URL | Jun 10 2025, 02:40 PM |
Fix Vector Delete API Documentation to Show Single Key Deletion
Problem
The documentation for both JavaScript and Python SDKs incorrectly shows the vector delete API as supporting multiple IDs:
delete(name: string, ...ids: string[])delete(name: str, *ids: str)However, the actual implementations in both SDKs only support single key deletion:
delete(name: string, key: string)delete(name: str, key: str)This inconsistency was introduced when PR #125 in sdk-js was initially designed to support multiple IDs but was later reverted back to single key deletion based on backend API limitations. The documentation was never updated to reflect this change.
Solution
Updated all documentation to accurately reflect the single key deletion API:
Changes Made
JavaScript SDK API Reference (
content/SDKs/javascript/api-reference.mdx)delete(name: string, ...ids: string[])todelete(name: string, key: string)Python SDK API Reference (
content/SDKs/python/api-reference.mdx)delete(name: str, *ids: str)todelete(name: str, key: str)JavaScript SDK Examples (
content/SDKs/javascript/examples/index.mdx)Python SDK Examples (
content/SDKs/python/examples/index.mdx)Verification
Link to Devin run
https://app.devin.ai/sessions/d6871f24d93e498baeada2ec360b1bec
Requested by
jhaynie@agentuity.com