linux-raspberrypi: stop setting powersave as the default CPU governor #1231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clopez
force-pushed
the
fix_default_cpu_governor
branch
from
7ab5a4e to
22a28b0
Compare
agherzan
force-pushed
the
fix_default_cpu_governor
branch
from
22a28b0 to
dc90358
Compare
* The defconfigs from the RPi Kernel set `powersave` as the default CPU governor, which is a bad idea as that reduces performance by setting the CPU frequency to the minimum one. * In case of a Yocto build user-space is not configured by default to change the CPU governor, so `powersave` will remain the CPU governor and it will slow down everything. * I submitted a fix for those defconfigs to upstream here: raspberrypi/linux#5666 However, we shouldn't wait until that is accepted and backported to all the stable branches (if ever is). * This patch unsets the selection of `powersave` as the default CPU governor. * Then the CPU governor that will be selected as default after this patch will be the Linux's default one that is either `ondemand` or `schedutil` depending on the Kernel version. Signed-off-by: Carlos Alberto Lopez Perez <clopez@igalia.com>
agherzan
force-pushed
the
fix_default_cpu_governor
branch
from
dc90358 to
1248b3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The defconfigs from the RPi Kernel set
powersaveas the default CPU governor, which is a bad idea as that reduces performance by setting the CPU frequency to the minimum one.In case of a Yocto build user-space is not configured by default to change the CPU governor, so
powersavewill remain the CPU governor and it will slow down everything.I submitted a fix for those defconfigs to upstream here: configs: stop defaulting to the powersave governor raspberrypi/linux#5666 However, we shouldn't wait until that is accepted and backported to all the stable branches (if ever is).
This patch unsets the selection of
powersaveas the default CPU governor.Then the CPU governor that will be selected as default after this patch will be the Linux's default one that is either
ondemandorschedutildepending on the Kernel version.