pause(): Fixed handling for same status and changed toggle logic#3
Open
RiZKiT wants to merge 1 commit intoaglemann:masterfrom
Open
pause(): Fixed handling for same status and changed toggle logic#3RiZKiT wants to merge 1 commit intoaglemann:masterfrom
RiZKiT wants to merge 1 commit intoaglemann:masterfrom
Conversation
RiZKiT
commented
Apr 27, 2012
RiZKiT
commented
- Fixed handling when p == this.paused. That broke the slideshow animation before, now it just returns, because nothing has to be changed
- Changed toggle logic code, that was a bit too cryptic and mind bending before (this.paused was play and vice verca) and switched pause and play code block then.
- Added true/false support info
…nimation before, now it just returns, because nothing has to be changed - Improved toggle logic. That was a bit too cryptic and mind bending before (this.paused was play and vice verca) - switched pause and play code block - added true/false support info
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.