fix: correct typo boot_sources_shapshot → boot_sources_snapshot#95
Open
newgoliath wants to merge 1 commit intomainfrom
Open
fix: correct typo boot_sources_shapshot → boot_sources_snapshot#95newgoliath wants to merge 1 commit intomainfrom
newgoliath wants to merge 1 commit intomainfrom
Conversation
The variable ocp4_workload_openshift_virtualization_boot_sources_shapshot
was misspelled ("shapshot" instead of "snapshot") in defaults, tasks, and
template. No existing catalog items use this v2 variable name, so this
is a safe rename with no breaking changes.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
newgoliath
requested review from
agonzalezrh,
fridim,
rut31337,
stencell and
wkulhanek
as code owners
wkulhanek
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ocp4_workload_openshift_virtualization_boot_sources_shapshotwas misspelled ("shapshot" instead of "snapshot") in 3 files:defaults/main.ymltasks/workload.ymltemplates/hyperconverged.yaml.j2ocp4_workload_openshift_virtualization_*), so this is a safe rename with no breaking changesocp4_workload_kubevirt_boot_sources_shapshotused by existing configs is a different workload and is unaffectedTest plan
ocp4_workload_openshift_virtualization_boot_sources_snapshot: falseenableCommonBootImageImport: falseGenerated with Claude Code