Fix for deadlock in logging#10
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deadlock is happening when 2 threads in the client try to log at the same time. Example thread dump here: https://gist.github.com/bdew/d6a2e1372dec8864403395ead8f7a2ac
Easiest way to reproduce is to pray right after you log in, if you're (un)lucky you'll get the 2 following lines emitted at the same time and your client will hang:
Making this method non-synchronized seems to fix it, and i don't see any particular reason for it to be - it only accesses a thread local value and System.out.println which is synchronized on it's own (and that's part of why it deadlocks) - so i just left it at that.
Compiled build for testing here - https://www.dropbox.com/s/7xwwa43wi86mj91/client-modlauncher-0.8-hangfix.zip?dl=0