Remove pre-devscripts 2.10.70 compat code

[Unit193]

Remove pre-devscripts 2.10.70 compat code, no longer matches current output anyway.

This also allows uscan to adhere to the users configuration.

[agx]

Thanks! I've added to nits inline. Can you make the commit message a bit more catchy (I had to look up what this was about in the first place). E.g. like

Remove pre-devscripts 2.10.70 compat code

We can rely on the <target> element being present in the xml.

[Unit193]

Oh yes, that's a bit cryptic if one doesn't look at the actual changes. It's not too interesting of a change really, but a little explaining will help. Hopefully you like what I just pushed, if not I'm not really attached to what's written anyway.

[agx]

@Unit193 thanks. Your commit still tries to squeeze a behaviour change (dropping --symlink with a cleanup so I split that part out.

I'm fine to apply the symlink bit as well but please see https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=914314 - did you test that scenario? If so let me know and I'll push that out as well (keeping your authorship).

Alternative would be to pass --symlink only when --tarball-dir is in effect too.

[Unit193]

I figured they were related, my main goal was to remove --symlink so that I could finally make use of the --uscan option. Importing seemed to work fine but I didn't really have any exotic configuration. I'd be more than willing to test anything that'll help get rid of --symlink though.

[agx]

I figured they were related, my main goal was to remove --symlink so that I could finally make use of the --uscan option.

That's why we really want that as a separate commit. Did you check --tarball-dir works as expected with your patch (I haven't yet).

[Unit193]

I haven't, but is something else you get from DEHS out of uscan. Maybe that could be utilized at some point.

[agx]

Checking --tarball-dir and maybe even adding a test for that would be great.

[Unit193]

I'm not very well versed in python so beyond basic changes, and writing tests, I'm out of luck. For the time being I have a trigger that strips --symlink out of /usr/lib/python3/dist-packages/gbp/deb/uscan.py, so it works. Thanks for following up!