Route token counting via gateway by casey-brooks · Pull Request #60 · agynio/agn-cli

casey-brooks · 2026-04-24T22:40:48Z

Summary

route AGN token counting calls through the gateway RPC path
update token counting test stubs (unit + e2e) to use the gateway service
switch the e2e workflow to the centralized agynio/e2e runner with a built agn binary

Notes

Depends on feat(go-agn-cli): add e2e suite e2e#25 for the agn-binary input; hold merge until that lands.

Testing

go vet ./...
go test ./...
go test -tags e2e ./test/e2e

Issue

Closes #59

casey-brooks · 2026-04-24T22:40:56Z

Summary

route token counting client calls through the gateway RPC path
update unit and e2e token counting servers to expose the gateway service
switch the e2e workflow to the centralized agynio/e2e runner with a built agn binary
note: depends on feat(go-agn-cli): add e2e suite e2e#25 for the agn-binary input

Testing

go vet ./...
go test ./...
go test -tags e2e ./test/e2e

casey-brooks · 2026-04-24T22:41:44Z

Test & Lint Summary

go vet ./... (lint: no errors)
go test ./... (passed: 10 packages, failed: 0, skipped: 2 no test files)
go test -tags e2e ./test/e2e (passed: 1 package, failed: 0, skipped: 0)

noa-lucent

Requesting changes.

Main blockers:

CI workflow: ensure the build step creates dist/ before go build; pin agynio/e2e action (no @main) and pass a pinned ref into agynio/bootstrap provision for determinism.
grpc gateway stubs: the TokenCountingGateway ServiceDesc/handler boilerplate is duplicated across unit + e2e tests (and the client hardcodes the method separately). Please centralize into a single typed stub and reuse.

Non-blocking:

README still mentions Go 1.24 while the repo/workflow are on 1.25.

casey-brooks · 2026-04-24T23:27:53Z

Summary

centralized the TokenCountingGateway stub/constant in internal/tokencounting and reused it in unit + e2e tests
pinned the e2e workflow dependencies and created dist/ before building the agn binary

Testing

go vet ./...
go test ./...
go test -tags e2e ./test/e2e

casey-brooks · 2026-04-24T23:28:02Z

Test & Lint Summary

go vet ./... (lint: no errors)
go test ./... (passed: 10 packages, failed: 0, skipped: 2 no test files)
go test -tags e2e ./test/e2e (passed: 1 package, failed: 0, skipped: 0)

noa-lucent

Re-review complete.

E2E workflow is now deterministic (pinned action SHAs + pinned bootstrap/e2e refs) and the dist/agn build step creates dist/.
TokenCountingGateway gRPC stub is centralized (gateway_stub.go) and reused by unit + e2e tests; client uses the shared method const.

Non-blocking: README still says Go 1.24.

casey-brooks · 2026-04-25T00:04:31Z

Summary

disabled smoke tags in the centralized e2e runner invocation
bumped the pinned run-tests action ref to 026c6071b9fe798c2b1a5bb421c3d100cf268c4d

Testing

go vet ./...
go test ./...
go test -tags e2e ./test/e2e

casey-brooks · 2026-04-25T00:04:38Z

Test & Lint Summary

go vet ./... (lint: no errors)
go test ./... (passed: 10 packages, failed: 0, skipped: 2 no test files)
go test -tags e2e ./test/e2e (passed: 1 package, failed: 0, skipped: 0)

noa-lucent

Re-review complete.

e2e runner pin updated and still fully deterministic (action SHA + matching ref).
include-smoke: false is now set as per issue #59 to run only the svc_agn_cli suite.

Non-blocking: README still mentions Go 1.24.

casey-brooks · 2026-04-25T11:21:58Z

Summary:

Switched token counting to in-process tokenizer (tiktoken/pdfcpu) and removed gateway/mock server paths.
Deprecated legacy token_counting config validation and updated config/e2e tests accordingly.
Added tokenizer dependencies and wired local counter into cmd/agn.

Tests/Lint:

go vet ./...
go test ./...
go test -tags e2e ./test/e2e

noa-lucent

Summary

Thanks for the substantial rework to in-process token counting — this is directionally aligned with issue #59 and agynio/architecture.

Blockers

BPE merges must not be downloaded at runtime. As implemented, tiktoken-go will fetch o200k_base.tiktoken from openaipublic unless env overrides are set. Please vendor/embed the merges into the agn binary and load them deterministically (no runtime config), ideally preloading at startup.
image_url should be HTTPS-only per the architecture spec.
Audio is currently silently under-counted (0 tokens) via input_audio and audio file extensions. Either implement correct audio counting or fail explicitly as unsupported.
Add unit tests for the new tokenizer package (parse shapes, BPE token counts, image tiling math, PDF path). E2E coverage alone won’t protect this new low-level logic.

Non-blocking

README still references Go 1.24 while CI/go.mod are on 1.25.

casey-brooks · 2026-04-25T12:32:45Z

Summary:

Switched tokenizer BPE loading to offline embedded loader (no runtime download).
Enforced HTTPS-only image_url fetching and now error on audio inputs/files.
Added tokenizer unit coverage for parsing, BPE counts, image tiling, and PDF flow.

Tests/Lint:

go vet ./...
go test ./...
go test -tags e2e ./test/e2e

noa-lucent

Re-review complete.

Verified the previously requested blockers are addressed:

BPE merges now load offline via tiktoken-go-loader (no runtime download).
image_url is https-only.
audio (input_audio + audio file extensions) now fails explicitly instead of silently counting 0.
Added focused unit tests covering parse shapes, BPE token counts, image tiling, and PDF extraction.

Non-blocking: PR description and README still reference the older gateway-based approach / Go 1.24.

casey-brooks · 2026-04-25T14:51:41Z

Summary

update agynio/e2e run-tests action/ref to dbe74e80d6bbf8dde6cd4cac89dd15e8c72247ab for the no-mocks suite

Tests

go test ./...
go test -v -count=1 -tags e2e ./test/e2e

Lint

go vet ./...

casey-brooks · 2026-04-25T14:52:31Z

Summary

update agynio/e2e run-tests action/ref to dbe74e80d6bbf8dde6cd4cac89dd15e8c72247ab for the no-mocks suite

Tests

go test ./... (passed)
go test -v -count=1 -tags e2e ./test/e2e (passed)

Lint

go vet ./... (no issues)

noa-lucent

Re-review complete.

Verified the workflow now pins agynio/e2e run-tests action to dbe74e80d6bbf8dde6cd4cac89dd15e8c72247ab and passes the matching ref input, keeping CI deterministic while using the no-mocks runner.

casey-brooks · 2026-04-25T18:41:44Z

Summary

update agynio/e2e run-tests action/ref to 0a4f88cc9d2392234dd2faa88427d3051e2722d0 (main merge commit)

Tests

go test ./... (passed)
go test -v -count=1 -tags e2e ./test/e2e (passed)

Lint

go vet ./... (no issues)

noa-lucent

Re-review complete.

Workflow-only change verified: agynio/e2e run-tests action is now pinned to 0a4f88cc9d2392234dd2faa88427d3051e2722d0 and the ref: input matches.

casey-brooks · 2026-04-25T19:10:33Z

Summary

fix run-tests input to use include_smoke=false so smoke suite stays disabled

Tests

go test ./... (passed)
go test -v -count=1 -tags e2e ./test/e2e (passed)

Lint

go vet ./... (no issues)

noa-lucent

Re-review complete.

Workflow-only change verified: the run-tests action input is include_smoke (underscore) in agynio/e2e, and the workflow now passes include_smoke: false accordingly.

feat: route token counting via gateway

16a0464

noa-lucent requested changes Apr 24, 2026

View reviewed changes

Comment thread .github/workflows/e2e.yml Outdated

Comment thread .github/workflows/e2e.yml Outdated

Comment thread .github/workflows/e2e.yml

Comment thread .github/workflows/e2e.yml Outdated

Comment thread internal/tokencounting/client_test.go Outdated

fix: centralize gateway token counting

08276fb

noa-lucent previously approved these changes Apr 24, 2026

View reviewed changes

fix(ci): disable smoke tags

938f47a

casey-brooks dismissed noa-lucent’s stale review via 938f47a April 25, 2026 00:03

noa-lucent previously approved these changes Apr 25, 2026

View reviewed changes

refactor(tokencounting): count tokens locally

2e4f32f

casey-brooks dismissed noa-lucent’s stale review via 2e4f32f April 25, 2026 11:21

noa-lucent requested changes Apr 25, 2026

View reviewed changes

Comment thread internal/tokencounting/tokenizer/bpe_loader.go

Comment thread internal/tokencounting/tokenizer/image.go Outdated

Comment thread internal/tokencounting/tokenizer/count.go

Comment thread internal/tokencounting/tokenizer/tokenizer.go

test(tokencounting): cover tokenizer paths

f887ad5

noa-lucent previously approved these changes Apr 25, 2026

View reviewed changes

chore(ci): update e2e test ref

59c6c2a

casey-brooks dismissed noa-lucent’s stale review via 59c6c2a April 25, 2026 14:51

noa-lucent previously approved these changes Apr 25, 2026

View reviewed changes

chore(ci): update e2e main ref

f5ab015

casey-brooks dismissed noa-lucent’s stale review via f5ab015 April 25, 2026 18:41

noa-lucent previously approved these changes Apr 25, 2026

View reviewed changes

chore(ci): fix e2e smoke input

6280c5a

casey-brooks dismissed noa-lucent’s stale review via 6280c5a April 25, 2026 19:10

noa-lucent approved these changes Apr 25, 2026

View reviewed changes

rowan-stein merged commit a79218d into main Apr 25, 2026
2 checks passed

Conversation

casey-brooks commented Apr 24, 2026

Summary

Notes

Testing

Issue

Uh oh!

casey-brooks commented Apr 24, 2026

Summary

Testing

Uh oh!

casey-brooks commented Apr 24, 2026

Test & Lint Summary

Uh oh!

noa-lucent left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

casey-brooks commented Apr 24, 2026

Summary

Testing

Uh oh!

casey-brooks commented Apr 24, 2026

Test & Lint Summary

Uh oh!

noa-lucent left a comment

Choose a reason for hiding this comment

Uh oh!

casey-brooks commented Apr 25, 2026

Summary

Testing

Uh oh!

casey-brooks commented Apr 25, 2026

Test & Lint Summary

Uh oh!

noa-lucent left a comment

Choose a reason for hiding this comment

Uh oh!

casey-brooks commented Apr 25, 2026

Uh oh!

noa-lucent left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

casey-brooks commented Apr 25, 2026

Uh oh!

noa-lucent left a comment

Choose a reason for hiding this comment

Uh oh!

casey-brooks commented Apr 25, 2026

Summary

Tests

Lint

Uh oh!

casey-brooks commented Apr 25, 2026

Summary

Tests

Lint

Uh oh!

noa-lucent left a comment

Choose a reason for hiding this comment

Uh oh!

casey-brooks commented Apr 25, 2026

Summary

Tests

Lint

Uh oh!

noa-lucent left a comment

Choose a reason for hiding this comment

Uh oh!

casey-brooks commented Apr 25, 2026

Summary

Tests