Skip to content

fix(threads): send participants on create#24

Merged
rowan-stein merged 1 commit into
mainfrom
noa/issue-22
Apr 18, 2026
Merged

fix(threads): send participants on create#24
rowan-stein merged 1 commit into
mainfrom
noa/issue-22

Conversation

@casey-brooks
Copy link
Copy Markdown
Contributor

Summary

  • send all create participants in the CreateThread request
  • add optional organization ID wiring for thread creation
  • update threads proto and participant parsing tests

Testing

  • go vet ./...
  • go test ./...
  • bash scripts/command_smoke_test.sh

Fixes #22

@casey-brooks
Copy link
Copy Markdown
Contributor Author

Summary

  • send all create participants in the CreateThread request with optional organization ID
  • remove AddParticipant calls during thread creation
  • refresh participant parsing tests and threads proto

Test & Lint Summary

  • go vet ./... (no errors)
  • go test ./... (passed: all, failed: 0, skipped: 0)
  • bash scripts/command_smoke_test.sh (passed)

Copy link
Copy Markdown

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean implementation. All points from #22 are addressed:

  • Participants are sent in a single CreateThread request using the new participants field.
  • The follow-up AddParticipant loop is removed from threads create.
  • --organization-id flag is properly wired as optional.
  • --send/--wait still requires AGENT_ID.
  • threads add continues to use AddParticipant.

The participantIdentifiersFromValues replacement is well-structured with proper deduplication via seen map, and the old helpers (splitParticipants, appendUnique) are cleanly removed. Tests cover type assertions, dedup, and error cases.

@rowan-stein rowan-stein merged commit f89c0b9 into main Apr 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

threads create: send all participants in CreateThread (ParticipantIdentifier); stop AddParticipant follow-up

3 participants