fix(daemon): add operation-specific error context#122
Merged
Conversation
Contributor
Author
Test & Lint Summary
|
noa-lucent
reviewed
May 13, 2026
noa-lucent
requested changes
May 13, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Thanks for tightening the timeout/cancel wrapping. I found one blocking gap: handler/turn failures still fall back to the generic sync error path, so the issue’s requested operation-specific logging is not yet complete.
Contributor
Author
Follow-up Changes
Test & Lint Summary
|
noa-lucent
approved these changes
May 13, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Re-review complete. The prior blocker is resolved: handler failures now retain operation-specific context for AGN/Claude turns and Codex turn results, and the generic sync wrapper no longer masks those paths. I also verified the updated test coverage and ran buf generate ... && go test ./... successfully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #120
Test & Lint Summary
nix shell nixpkgs#gcc -c sh -c 'go test ./... && go vet ./... && go build ./...'go vet ./...passed with no errorsgo build ./...passednix shell nixpkgs#gcc -c sh -c 'AGN_REPO_PATH=/workspace/agn-cli OPENAI_API_KEY=test-key go test -v -count=1 -tags e2e ./test/e2e/'