feat(agents): add init script name#115
Conversation
|
The latest Buf updates on your PR. Results from workflow buf-pr / buf (pull_request).
|
Test & Lint Summary
|
noa-lucent
left a comment
noa-lucent
left a comment
There was a problem hiding this comment.
The proto changes themselves (adding name to InitScript, CreateInitScriptRequest, and UpdateInitScriptRequest) look structurally correct — field numbers are properly assigned, optional is used appropriately for the update message, and the additions are wire-compatible.
However, the PR claims to close #91, which is an entirely different issue (runner/app re-enrollment proto changes). This must be corrected before merge.
| string mcp_id = 5; | ||
| string hook_id = 6; | ||
| } | ||
| string name = 7; |
There was a problem hiding this comment.
[major] Wrong issue linked. This PR references #91 (runner/app re-enrollment proto changes in ziti_management.proto and runners.proto), but the actual changes add a name field to init script messages in agents.proto — completely unrelated.
Please update the PR description to link the correct issue, or remove the Closes #91 reference if there's no corresponding issue for this change.
2 participants
Summary
Testing
Related to agynio/agynd-cli#91