Skip to content

Add username search and profile APIs#132

Merged
vitramir merged 2 commits into
mainfrom
noa/issue-140
Apr 23, 2026
Merged

Add username search and profile APIs#132
vitramir merged 2 commits into
mainfrom
noa/issue-140

Conversation

@casey-brooks
Copy link
Copy Markdown
Contributor

Summary

  • add username to user contracts and provisioning input
  • expose self-service profile update and user directory search
  • add org nickname setter endpoint in organizations gateway

Testing

  • buf lint
  • buf breaking --against '.git#branch=main'

Refs #140

@casey-brooks casey-brooks requested a review from a team as a code owner April 23, 2026 19:46
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 23, 2026

The latest Buf updates on your PR. Results from workflow buf-pr / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedApr 23, 2026, 8:09 PM

@casey-brooks
Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

  • Tests: 0 passed, 0 failed, 0 skipped (no unit tests in repo)
  • Lint: buf lint (no errors)
  • Breaking check: buf breaking --against '.git#branch=main' (no errors)

Copy link
Copy Markdown

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking:

  • UpdateMeRequest should include optional string nickname to match the self-service profile requirements in agynio/architecture#140 (nickname + username + name). Right now clients would still need the admin-only UpdateUser to edit nickname.

Non-blocking:

  • Consider optional int32 limit (or docs for 0 => default) for SearchUsersRequest.limit (spec default=10, max=20).
  • Since usernames aren’t backfilled, consider making User.username optional or documenting that empty means “unset” during rollout.

Comment thread proto/agynio/api/users/v1/users.proto
Comment thread proto/agynio/api/users/v1/users.proto
Comment thread proto/agynio/api/users/v1/users.proto
@casey-brooks
Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

  • Tests: 0 passed, 0 failed, 0 skipped (no unit tests in repo)
  • Lint: buf lint (no errors)
  • Breaking check: buf breaking --against '.git#branch=main' (no errors)

Copy link
Copy Markdown

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates look good.

  • UpdateMe is now clearly scoped to cluster-wide fields, with org nickname updates handled via OrganizationsService.SetMyOrgNickname.
  • Added docs for username unset rollout and SearchUsers.limit default/max.

@vitramir vitramir merged commit 069736a into main Apr 23, 2026
1 check passed
casey-brooks added a commit that referenced this pull request Apr 25, 2026
* feat(api): add user search and profile APIs

* docs(api): clarify nickname updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants