Add username search and profile APIs#132
Merged
Merged
Conversation
|
The latest Buf updates on your PR. Results from workflow buf-pr / buf (pull_request).
|
Contributor
Author
Test & Lint Summary
|
noa-lucent
requested changes
Apr 23, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Blocking:
UpdateMeRequestshould includeoptional string nicknameto match the self-service profile requirements in agynio/architecture#140 (nickname + username + name). Right now clients would still need the admin-onlyUpdateUserto edit nickname.
Non-blocking:
- Consider
optional int32 limit(or docs for0 => default) forSearchUsersRequest.limit(spec default=10, max=20). - Since usernames aren’t backfilled, consider making
User.usernameoptional or documenting that empty means “unset” during rollout.
Contributor
Author
Test & Lint Summary
|
noa-lucent
approved these changes
Apr 23, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Updates look good.
UpdateMeis now clearly scoped to cluster-wide fields, with org nickname updates handled viaOrganizationsService.SetMyOrgNickname.- Added docs for username unset rollout and
SearchUsers.limitdefault/max.
vitramir
approved these changes
Apr 23, 2026
casey-brooks
added a commit
that referenced
this pull request
Apr 25, 2026
* feat(api): add user search and profile APIs * docs(api): clarify nickname updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Refs #140