Skip to content

feat(runners): add workload failure fields#135

Merged
vitramir merged 2 commits into
mainfrom
noa/issue-161
Apr 24, 2026
Merged

feat(runners): add workload failure fields#135
vitramir merged 2 commits into
mainfrom
noa/issue-161

Conversation

@casey-brooks
Copy link
Copy Markdown
Contributor

@casey-brooks casey-brooks commented Apr 24, 2026

Summary

  • add workload failure reason/message fields to runners protos
  • extend ListWorkloadsByThread filters and ordering comment

Refs: agynio/agents-orchestrator#161

@casey-brooks casey-brooks requested a review from a team as a code owner April 24, 2026 19:57
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 24, 2026

The latest Buf updates on your PR. Results from workflow buf-pr / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedApr 24, 2026, 8:36 PM

@casey-brooks
Copy link
Copy Markdown
Contributor Author

Summary

  • add workload failure reason/message fields to runners protos
  • extend ListWorkloadsByThread filters and ordering note

Testing

  • buf lint
  • buf breaking --against '.git#branch=main'

@casey-brooks
Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

Commands:

  • buf lint
  • buf breaking --against '.git#branch=main'

Results:

  • Tests: passed 0, failed 0, skipped 0 (no unit tests)
  • Lint: no errors

Copy link
Copy Markdown

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes:

  • Please address the API naming consistency issue for the new status filter (see inline [major]).
  • Add/clarify semantics/docs for workload failure fields and ListWorkloadsByThread ordering (see inline [minor]).

Note: PR description references “#161”, but there’s no issue/PR 161 in agynio/api; please link the correct issue if it’s cross-repo.

Comment thread proto/agynio/api/runners/v1/runners.proto Outdated
Comment thread proto/agynio/api/runners/v1/runners.proto
Comment thread proto/agynio/api/runners/v1/runners.proto
Comment thread proto/agynio/api/runners/v1/runners.proto Outdated
@casey-brooks
Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

Commands:

  • buf lint
  • buf breaking --against '.git#branch=main'

Results:

  • Tests: passed 0, failed 0, skipped 0 (no unit tests)
  • Lint: no errors

Copy link
Copy Markdown

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review complete — requested changes addressed (filter naming consistency, failure field semantics docs, and stable ordering note).

@vitramir vitramir merged commit 5d52227 into main Apr 24, 2026
1 check passed
casey-brooks added a commit that referenced this pull request Apr 25, 2026
* feat(runners): add workload failure fields

* docs(runners): clarify failure fields
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants