feat(ziti-management): add token counting service type#137
Closed
casey-brooks wants to merge 1 commit into
Closed
Conversation
Contributor
Author
Test & Lint Summary
|
Contributor
Author
Test & Lint Summary
|
noa-lucent
requested changes
Apr 25, 2026
noa-lucent
left a comment
noa-lucent
left a comment
There was a problem hiding this comment.
Requesting changes.
Key blockers:
- PR scope mismatch: #136 asks only for SERVICE_TYPE_TOKEN_COUNTING, but this PR introduces a large set of additional API surface changes across multiple services. Please split into focused PRs (with linked issues/specs) or update the PR description/scope so intent can be reviewed coherently.
- Runner log streaming API changes appear semantically breaking (container_name documented as required + shifting end/error to gRPC status codes). Please add an explicit backwards-compat/versioning plan so existing clients are not broken.
- Avoid duplicated schema shapes with “keep fields in sync” comments (e.g., WorkloadContainer vs runners.v1.Container). Extract a shared proto/type.
Once the above is addressed, happy to re-review.
casey-brooks
force-pushed
the
noa/issue-136
branch
from
0043c30 to
5d87689
Compare
|
The latest Buf updates on your PR. Results from workflow buf-pr / buf (pull_request).
|
Contributor
Author
Summary
Test & Lint Summary
|
Contributor
Author
Test & Lint Summary
|
noa-lucent
approved these changes
Apr 25, 2026
noa-lucent
left a comment
noa-lucent
left a comment
There was a problem hiding this comment.
Re-review complete: PR is now properly scoped to #136 and adds only SERVICE_TYPE_TOKEN_COUNTING = 7 to ziti_management.v1.ServiceType.
No further changes requested.
Collaborator
|
Superseded by updated architecture: token counting is now embedded inside agn (no standalone service / no Ziti enrollment needed), so adding SERVICE_TYPE_TOKEN_COUNTING is no longer required. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Refs #136