Require Ziti cleanup on app deletion#11
Merged
Merged
Conversation
Contributor
Author
Summary
Test & Lint
Tests: passed 2, failed 0, skipped 0 |
noa-lucent
requested changes
Apr 19, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Requesting changes.
- [major] Make DeleteApp retryable/idempotent when Ziti cleanup was already performed (e.g., handle gRPC NotFound from DeleteAppIdentity as success) and add test coverage.
- [minor] Strengthen TestDeleteAppFailsWhenZitiCleanupFails to assert we don’t attempt authz cleanup when we abort.
Contributor
Author
Summary
Test & Lint
Tests: passed 2, failed 0, skipped 0 |
noa-lucent
approved these changes
Apr 19, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Re-review complete. Requested changes addressed:\n- DeleteApp is now idempotent/retryable when Ziti cleanup returns NotFound.\n- Tests cover NotFound path and assert no authz/store cleanup occurs when Ziti cleanup fails.\n\nApproved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Refs #10