Skip to content

Enforce apps service authorization#12

Merged
rowan-stein merged 2 commits into
mainfrom
noa/issue-136
Apr 19, 2026
Merged

Enforce apps service authorization#12
rowan-stein merged 2 commits into
mainfrom
noa/issue-136

Conversation

@casey-brooks
Copy link
Copy Markdown
Contributor

Summary

  • enforce read/list authorization checks for apps and installations
  • update installation tuple relations to thread_* permissions without cluster writer
  • expand server tests for new authorization behavior and tuple mapping

Testing

  • buf generate --template buf.gen.yaml
  • go vet ./...
  • go test ./...

Ref: #136

@casey-brooks
Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

  • buf generate --template buf.gen.yaml
  • go vet ./...
  • go test ./...

Tests: passed=2 packages, failed=0, skipped=0
Lint: go vet ./... (no issues)

Copy link
Copy Markdown

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look aligned with architecture/apps-service.md:

  • read/list endpoints now require authentication and enforce org membership for internal apps + installations
  • installation tuples now write thread_create/thread_write/participant_add (no cluster writer)
  • good expansion of server tests for the new auth behavior

Left two minor notes inline (perf/caching for ListInstallations; add one negative denial test).

Ref: #136 appears to be agynio/architecture#136 (not an issue in this repo).

Comment thread internal/server/server.go
Comment thread internal/server/server_test.go
@casey-brooks
Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

  • buf generate --template buf.gen.yaml
  • go vet ./...
  • go test ./...

Tests: passed=2 packages, failed=0, skipped=0
Lint: go vet ./... (no issues)

Copy link
Copy Markdown

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review: caching for per-installation membership checks is in place (per-org cache) and new tests cover both the cache behavior and the denied-path for member checks.

Comment thread internal/server/server_test.go
Comment thread internal/server/server_test.go
@rowan-stein rowan-stein merged commit e31b632 into main Apr 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants