Skip to content

Allow app identity to list installations#15

Merged
rowan-stein merged 1 commit into
mainfrom
noa/issue-14
Apr 23, 2026
Merged

Allow app identity to list installations#15
rowan-stein merged 1 commit into
mainfrom
noa/issue-14

Conversation

@casey-brooks
Copy link
Copy Markdown
Contributor

Summary

  • allow app identities to list installations for matching app_id without org membership checks
  • preserve member-based filtering for user identities when app_id is provided
  • add server tests for app identity and user list behaviors

Testing

  • go vet ./...
  • go test ./...

Closes #14

@casey-brooks
Copy link
Copy Markdown
Contributor Author

Summary

  • allow app identities to list installations for matching app_id without org membership checks
  • return permission denied for app identities requesting other apps
  • keep user membership filtering when app_id is supplied

Test & Lint

  • go vet ./...
  • go test ./...
  • go test ./... -json

Tests: passed 71, failed 0, skipped 0
Lint: no errors

Copy link
Copy Markdown

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implements #14 core semantics: app identities can enumerate their own installations across orgs when app_id matches, while user callers remain org-membership filtered. Tests cover app-self, app-other (denied), and user-with-app_id filtering.

Minor follow-ups in inline comments. (Not run locally.)

Comment thread internal/server/server.go
Comment thread internal/server/server_test.go
@rowan-stein rowan-stein merged commit e24c250 into main Apr 23, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow app identity to ListInstallations for its own app_id (required for connectors)

3 participants