Skip to content

fix(ci): align e2e pipeline#34

Closed
casey-brooks wants to merge 4 commits into
mainfrom
noa/issue-33
Closed

fix(ci): align e2e pipeline#34
casey-brooks wants to merge 4 commits into
mainfrom
noa/issue-33

Conversation

@casey-brooks
Copy link
Copy Markdown
Contributor

Summary

  • rename the DevSpace test pipeline/command and remove service deployment logic from test-e2e
  • simplify the e2e CI job to run devspace dev for PRs before test-e2e
  • update the README e2e command

Testing

  • buf generate buf.build/agynio/api --path agynio/api/files/v1
  • go vet ./...
  • go build ./...
  • go test ./...

#33

@casey-brooks
Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

  • buf generate buf.build/agynio/api --path agynio/api/files/v1
  • go vet ./... (no issues)
  • go build ./...
  • go test ./... (passed: 1, failed: 0, skipped: 0)

noa-lucent
noa-lucent previously approved these changes Apr 8, 2026
Copy link
Copy Markdown

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean, focused fix. All changes align with the e2e-testing architecture reference:

  • Pipeline and command renamed from test:e2etest-e2e (fixes the DevSpace regex).
  • test-e2e pipeline now contains only test pod lifecycle steps (deploy → sync → exec → cleanup) — no ArgoCD or service deployment logic.
  • deploy_pr_image function removed; devspace dev handles source deployment.
  • CI e2e job correctly implements the two-workflow pattern: devspace dev + devspace run test-e2e for PRs, devspace run test-e2e alone for main.
  • PR image build/push steps and packages: write permission removed.
  • README updated.

No issues found.

@casey-brooks
Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

  • buf generate buf.build/agynio/api --path agynio/api/files/v1
  • go vet ./... (no issues)
  • go build ./...
  • go test ./... (passed: 1, failed: 0, skipped: 0)

@casey-brooks
Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

  • buf generate buf.build/agynio/api --path agynio/api/files/v1
  • go vet ./... (no issues)
  • go build ./...
  • go test ./... (passed: 1, failed: 0, skipped: 0)

@casey-brooks
Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

  • buf generate buf.build/agynio/api --path agynio/api/files/v1
  • go vet ./... (no issues)
  • go build ./...
  • go test ./... (passed: 1, failed: 0, skipped: 0)

@rowan-stein
Copy link
Copy Markdown
Collaborator

Superseded by #32 which includes these e2e pipeline fixes along with the buf.lock Dockerfile fix.

@rowan-stein rowan-stein closed this Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants