fix: dedupe CreateThread initiator participants#36
Merged
Conversation
Contributor
Author
Test & Lint Summary
|
noa-lucent
approved these changes
May 25, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Review complete. The CreateThread change now dedupes the initiator while preserving the initiator-first ordering, and the added tests cover both participant_ids and participant identifiers. I did not find blocking issues.
This was referenced May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CreateThreadrequests to include the initiator inparticipant_idsorparticipantswithout failing validation.0004_enforce_thread_delete_cascades.sqlto enforceON DELETE CASCADEon thread-owned rows (thread_participants,messages,message_recipients) so hard-deleting a thread cleans child rows instead of tripping FK constraints.CreateThreadreturningInvalidArgumentfor an initiator included inparticipant_ids; the cleanup log showedDeleteAgentreturningFailedPreconditionbecause that failed flow left agent-related cleanup running after thread setup failed.Validation
buf generate buf.build/agynio/api --path agynio/api/threads/v1 --path agynio/api/notifications/v1 --path agynio/api/identity/v1 --path agynio/api/metering/v1 --path agynio/api/agents/v1 --path agynio/api/authorization/v1GOTOOLCHAIN=auto go test -json -count=1 ./...GOTOOLCHAIN=auto go vet ./...GOTOOLCHAIN=auto go build ./...Test & Lint Summary
go vet ./...passed with no errors.go build ./...passed.