Skip to content

Some JSDoc's improvements & comparison with 'undefined'#9

Open
AlexeyAndKartashov wants to merge 2 commits intoaheckmann:masterfrom
AlexeyAndKartashov:master
Open

Some JSDoc's improvements & comparison with 'undefined'#9
AlexeyAndKartashov wants to merge 2 commits intoaheckmann:masterfrom
AlexeyAndKartashov:master

Conversation

@AlexeyAndKartashov
Copy link

For exclude PhpStorm's warning highlight.

before:
before

after:
after

@aheckmann-pebble
Copy link

Jsdoc changes look good. Please explain why the code changes are needed.

@AlexeyAndKartashov
Copy link
Author

AlexeyAndKartashov commented Jun 3, 2016

Because typeof slice (second argument) may be a undefined. Comparison between number & undefined may produce different result in different js engines (perhaps). You know it =)
Just code has become a little bit a unified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants