feat: add support for global zigopt setting#561
Merged
aherrmann merged 3 commits intoaherrmann:mainfrom Oct 28, 2025
Merged
Conversation
Addition to aherrmann#530 This allows to pass global arbitrary Zig compiler options to all compile actions. One useful usage is to set -mcpu=native from a common:native config statement so that all compile actions receive the flag.
cerisier
changed the title
aherrmann
reviewed
Oct 27, 2025
Owner
aherrmann
left a comment
aherrmann
left a comment
There was a problem hiding this comment.
Thanks! Yes, that could be quite useful.
I think the docs should carry the same warning as the zigopts attribute on the other Zig rules. They should also make clear that this does not override the zigopts attribute, but add to it.
One useful usage is to set -mcpu=native from a common:native config statement so that all compile actions receive the flag.
I think that specific case would probably be better served with a cpu attribute on the zig_target_toolchain rule. The -mcpu flag (and related flags) are really a platform concern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addition to #530
This allows to pass global arbitrary Zig compiler options to all compile actions.
One useful usage is to set -mcpu=native from a common:native config statement so that all compile actions receive the flag.
Added usual tests. WDYT ?