Significantly improve event matching/filtering#2
Merged
ahobsonsayers merged 7 commits intomainfrom Jul 2, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Significantly improve event filtering/matching by improving the normalisation of the event names and by implementing a home rolled string similarity algorithm for event names.
The string similarity algorithm works by using a modified Smith-Waterman local alignment algorithm to align a substring (desired event name) with a target string (the actual even name), and then a optimal string alignment Damerau-Levenshtein to calculate similarity on a word level within the substring. Word similarity is then averaged across all the words, after best alignment, to give the final similarity score.
This home rolled algorithm seems very robust and extremely suitable for our use case. This can be seen in the tests for the algorithm.