Skip to content

DO NOT swallow the exceptions #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wmazur-splunk wants to merge 1 commit into from
Closed

DO NOT swallow the exceptions #279

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions magic/loader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
from ctypes.util import find_library
import ctypes
import logging
import sys
import glob
import os.path
Expand Down Expand Up @@ -40,10 +41,12 @@ def load_lib():
# find_library returns None when lib not found
if lib is None:
continue
try:
return ctypes.CDLL(lib)
except OSError:
pass
if os.path.exists(lib):
try:
return ctypes.CDLL(lib)
except OSError as err:
logging.warning(err)
pass
Copy link

@bfontaine bfontaine May 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can remove this line now.

Copy link
Contributor

@cclauss cclauss May 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Suggested change
pass

Copy link
Contributor

@cclauss cclauss May 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Suggested change
pass

else:
# It is better to raise an ImportError since we are importing magic module
raise ImportError('failed to find libmagic. Check your installation')
Expand Down