Skip to content

docs: Adding redirects#3972

Closed
dagil-nvidia wants to merge 5 commits into
mainfrom
dagil/cherrypick-pr3965-docs-redirects
Closed

docs: Adding redirects#3972
dagil-nvidia wants to merge 5 commits into
mainfrom
dagil/cherrypick-pr3965-docs-redirects

Conversation

@dagil-nvidia
Copy link
Copy Markdown
Collaborator

@dagil-nvidia dagil-nvidia commented Oct 29, 2025

Cherry-pick: docs: Adding redirects

Overview

This PR cherry-picks PR #3965 (merged to main) to release/0.6.1 to add redirects for documentation pages that were moved in PR #3802.

Details

Adds 13 redirects to docs/conf.py to maintain accessibility of documentation URLs after the reorganization. Also updates docs/README.md with instructions on how to add redirects in the future.

Redirects Added

The following redirects were added to preserve access to moved documentation pages:

  • guides/tool-calling../agents/tool-calling.html
  • architecture/architecture../design_docs/architecture.html
  • architecture/disagg_serving../design_docs/disagg_serving.html
  • architecture/distributed_runtime../design_docs/distributed_runtime.html
  • architecture/dynamo_flow../design_docs/dynamo_flow.html
  • architecture/request_cancellation../fault_tolerance/request_cancellation.html
  • architecture/request_migration../fault_tolerance/request_migration.html
  • kubernetes/create_deployment../kubernetes/deployment/create_deployment.html
  • kubernetes/minikube../kubernetes/deployment/minikube.html
  • kubernetes/multinode-deployment../kubernetes/deployment/multinode-deployment.html
  • kubernetes/logging../kubernetes/observability/logging.html
  • kubernetes/metrics../kubernetes/observability/metrics.html
  • architecture/kv_cache_routing../router/kv_cache_routing.html

Related PRs

Where should the reviewer start?

  • docs/conf.py - Review redirect mappings
  • docs/README.md - Review redirect creation guidance

Testing

  • Verified cherry-pick applies cleanly to release/0.6.1
  • No merge conflicts
  • Redirects configuration matches the original PR

Summary by CodeRabbit

Release Notes: Version 0.6.1

  • Chores
    • Container images updated to official NVIDIA registry (nvcr.io/nvidia/ai-dynamo)
    • Version bumped to 0.6.1 across all components and configurations
    • CI/CD workflow enhanced with multi-platform build support (amd64 and arm64)
    • Documentation updated with navigation redirects for improved discoverability

nv-tusharma and others added 5 commits October 27, 2025 14:46
Signed-off-by: Tushar Sharma <tusharma@nvidia.com>
Signed-off-by: Tushar Sharma <tusharma@nvidia.com>
Signed-off-by: Tushar Sharma <tusharma@nvidia.com>
Signed-off-by: Tushar Sharma <tusharma@nvidia.com>
Signed-off-by: Andrew Schilling <aschilling@nvidia.com>
Signed-off-by: Dan Gil <dagil@nvidia.com>
@dagil-nvidia dagil-nvidia self-assigned this Oct 29, 2025
@dagil-nvidia dagil-nvidia requested a review from a team as a code owner October 29, 2025 21:44
@dagil-nvidia dagil-nvidia requested a review from a team October 29, 2025 21:44
@dagil-nvidia dagil-nvidia requested review from a team as code owners October 29, 2025 21:44
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Oct 29, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions Bot added the docs label Oct 29, 2025
@dagil-nvidia dagil-nvidia deleted the dagil/cherrypick-pr3965-docs-redirects branch October 29, 2025 21:45
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Oct 29, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This PR updates container image references across the codebase from placeholder registries and tags to production NVIDIA registries (nvcr.io/nvidia/ai-dynamo) with version 0.6.1. Additionally, it enables matrix-based platform testing in CI/CD, updates Helm chart versioning, and adds documentation redirects.

Changes

Cohort / File(s) Summary
CI/CD and Build Configuration
.github/workflows/container-validation-backends.yml, Earthfile, deploy/cloud/operator/Earthfile, deploy/cloud/operator/internal/secrets/docker_test.go
Container validation workflow enables matrix strategy for multi-platform testing (amd64 GPU, arm64 CPU). Docker server registry updated from my-registry to nvcr.io/nvidia/ai-dynamo in Earthfile targets. Test expectations updated to reflect new registry prefix.
Helm Chart and Versioning
deploy/cloud/helm/platform/Chart.yaml
Chart version bumped from 0.6.0 to 0.6.1; dynamo-operator dependency updated from 0.5.0 to 0.6.1.
sglang Deployment Manifests
components/backends/sglang/deploy/README.md, agg.yaml, agg_logging.yaml, agg_router.yaml, disagg.yaml, disagg-multinode.yaml, disagg_planner.yaml
Image tags updated from my-registry/sglang-runtime:my-tag to nvcr.io/nvidia/ai-dynamo/sglang-runtime:0.6.1 across all deployment configurations.
trtllm Deployment Manifests
components/backends/trtllm/deploy/README.md, agg.yaml, agg-with-config.yaml, agg_router.yaml, disagg.yaml, disagg-multinode.yaml, disagg_planner.yaml, disagg_router.yaml
Image references changed from my-registry/trtllm-runtime:my-tag to nvcr.io/nvidia/ai-dynamo/trtllm-runtime:0.6.1 across aggregated and disaggregated deployment patterns.
vllm Deployment Manifests
components/backends/vllm/deploy/README.md, agg.yaml, agg_kvbm.yaml, agg_router.yaml, disagg.yaml, disagg-multinode.yaml, disagg_kvbm.yaml, disagg_kvbm_2p2d.yaml, disagg_kvbm_tp2.yaml, disagg_planner.yaml, disagg_router.yaml
Image tags uniformly updated to nvcr.io/nvidia/ai-dynamo/vllm-runtime:0.6.1 across multiple vLLM deployment templates.
Configuration and Infrastructure
benchmarks/incluster/benchmark_job.yaml, benchmarks/profiler/utils/config.py, deploy/cloud/pre-deployment/nixl/README.md, build_and_deploy.sh, nixlbench-deployment.yaml, docs/kubernetes/deployment/create_deployment.md
Benchmark and deployment configs updated with concrete version 0.6.1 and registry nvcr.io/nvidia/ai-dynamo. Image pull secrets and runtime references aligned with new registry.
Example Deployments and Recipes
examples/basics/kubernetes/Distributed_Inference/*, examples/custom_backend/hello_world/deploy/hello_world.yaml, examples/deployments/ECS/*, examples/deployments/GKE/*, examples/multimodal/deploy/*, recipes/deepseek-r1/sglang/*, recipes/gpt-oss-120b/trtllm/agg/deploy.yaml, recipes/llama-3-70b/vllm/*, recipes/qwen3-32b-fp8/trtllm/*
Container image tags updated from my-tag to 0.6.1 and registry references standardized to nvcr.io/nvidia/ai-dynamo across all example and recipe deployments.
Test Configurations
tests/fault_tolerance/deploy/templates/vllm/moe_agg.yaml, moe_disagg.yaml, tests/planner/perf_test_configs/agg_8b.yaml, disagg_8b_2p2d.yaml, disagg_8b_3p1d.yaml, disagg_8b_planner.yaml, disagg_8b_tp2.yaml, image_cache_daemonset.yaml
All test deployment manifests updated with concrete image version 0.6.1.
Documentation
docs/README.md, docs/_includes/install.rst, docs/backends/trtllm/gpt-oss.md, docs/benchmarks/benchmarking.md, docs/conf.py
Installation instructions and benchmarking examples updated with version 0.6.1. Documentation build configuration enhanced with URL redirect mappings for guides, architecture, and Kubernetes documentation paths.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25–35 minutes

Areas requiring extra attention:

  • Consistency verification: Confirm all ~60 deployment files have consistent registry and version updates across sglang, trtllm, and vllm backends
  • Workflow platform matrix: Validate that the CI/CD matrix strategy correctly tests both amd64 (GPU) and arm64 (CPU) and that conditional exclusions for arm64 tests are properly applied
  • Chart version alignment: Verify that Helm chart version 0.6.1 and dynamo-operator dependency version 0.6.1 are compatible and correctly specified
  • Documentation redirects: Ensure the conf.py redirect mappings do not conflict with existing URL patterns and cover all intended documentation paths
  • Registry accessibility: Confirm nvcr.io/nvidia/ai-dynamo is the correct production registry path for deployment contexts

Poem

🐰 From my-registry's placeholder dreams,
We hop to NVIDIA's official streams!
Version 0.6.1 marks the way,
Sixty files in sync today.
Matrix platforms, redirects in place,
The dynamo bounces at a faster pace! 🚀


📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7b709c4 and cf6eea6.

📒 Files selected for processing (68)
  • .github/workflows/container-validation-backends.yml (5 hunks)
  • Earthfile (3 hunks)
  • benchmarks/incluster/benchmark_job.yaml (1 hunks)
  • benchmarks/profiler/utils/config.py (1 hunks)
  • components/backends/sglang/deploy/README.md (2 hunks)
  • components/backends/sglang/deploy/agg.yaml (2 hunks)
  • components/backends/sglang/deploy/agg_logging.yaml (2 hunks)
  • components/backends/sglang/deploy/agg_router.yaml (2 hunks)
  • components/backends/sglang/deploy/disagg-multinode.yaml (3 hunks)
  • components/backends/sglang/deploy/disagg.yaml (3 hunks)
  • components/backends/sglang/deploy/disagg_planner.yaml (4 hunks)
  • components/backends/trtllm/deploy/README.md (3 hunks)
  • components/backends/trtllm/deploy/agg-with-config.yaml (2 hunks)
  • components/backends/trtllm/deploy/agg.yaml (2 hunks)
  • components/backends/trtllm/deploy/agg_router.yaml (2 hunks)
  • components/backends/trtllm/deploy/disagg-multinode.yaml (3 hunks)
  • components/backends/trtllm/deploy/disagg.yaml (3 hunks)
  • components/backends/trtllm/deploy/disagg_planner.yaml (4 hunks)
  • components/backends/trtllm/deploy/disagg_router.yaml (3 hunks)
  • components/backends/vllm/deploy/README.md (2 hunks)
  • components/backends/vllm/deploy/agg.yaml (2 hunks)
  • components/backends/vllm/deploy/agg_kvbm.yaml (2 hunks)
  • components/backends/vllm/deploy/agg_router.yaml (2 hunks)
  • components/backends/vllm/deploy/disagg-multinode.yaml (3 hunks)
  • components/backends/vllm/deploy/disagg.yaml (3 hunks)
  • components/backends/vllm/deploy/disagg_kvbm.yaml (3 hunks)
  • components/backends/vllm/deploy/disagg_kvbm_2p2d.yaml (3 hunks)
  • components/backends/vllm/deploy/disagg_kvbm_tp2.yaml (3 hunks)
  • components/backends/vllm/deploy/disagg_planner.yaml (4 hunks)
  • components/backends/vllm/deploy/disagg_router.yaml (3 hunks)
  • deploy/cloud/helm/platform/Chart.yaml (1 hunks)
  • deploy/cloud/operator/Earthfile (1 hunks)
  • deploy/cloud/operator/internal/secrets/docker_test.go (5 hunks)
  • deploy/cloud/pre-deployment/nixl/README.md (1 hunks)
  • deploy/cloud/pre-deployment/nixl/build_and_deploy.sh (2 hunks)
  • deploy/cloud/pre-deployment/nixl/nixlbench-deployment.yaml (1 hunks)
  • docs/README.md (1 hunks)
  • docs/_includes/install.rst (2 hunks)
  • docs/backends/trtllm/gpt-oss.md (1 hunks)
  • docs/benchmarks/benchmarking.md (1 hunks)
  • docs/conf.py (1 hunks)
  • docs/kubernetes/deployment/create_deployment.md (1 hunks)
  • examples/basics/kubernetes/Distributed_Inference/README.md (1 hunks)
  • examples/basics/kubernetes/Distributed_Inference/agg_router.yaml (2 hunks)
  • examples/basics/kubernetes/Distributed_Inference/disagg_router.yaml (3 hunks)
  • examples/custom_backend/hello_world/deploy/hello_world.yaml (2 hunks)
  • examples/deployments/ECS/task_definition_frontend.json (1 hunks)
  • examples/deployments/ECS/task_definition_prefillworker.json (1 hunks)
  • examples/deployments/GKE/sglang/disagg.yaml (3 hunks)
  • examples/deployments/GKE/vllm/disagg.yaml (3 hunks)
  • examples/multimodal/deploy/agg_llava.yaml (4 hunks)
  • examples/multimodal/deploy/agg_qwen.yaml (4 hunks)
  • recipes/deepseek-r1/sglang/disagg-16gpu/deploy.yaml (3 hunks)
  • recipes/deepseek-r1/sglang/disagg-8gpu/deploy.yaml (3 hunks)
  • recipes/gpt-oss-120b/trtllm/agg/deploy.yaml (2 hunks)
  • recipes/llama-3-70b/vllm/agg/deploy.yaml (2 hunks)
  • recipes/llama-3-70b/vllm/disagg-multi-node/deploy.yaml (3 hunks)
  • recipes/llama-3-70b/vllm/disagg-single-node/deploy.yaml (3 hunks)
  • recipes/qwen3-32b-fp8/trtllm/agg/deploy.yaml (2 hunks)
  • recipes/qwen3-32b-fp8/trtllm/disagg/deploy.yaml (3 hunks)
  • tests/fault_tolerance/deploy/templates/vllm/moe_agg.yaml (2 hunks)
  • tests/fault_tolerance/deploy/templates/vllm/moe_disagg.yaml (3 hunks)
  • tests/planner/perf_test_configs/agg_8b.yaml (2 hunks)
  • tests/planner/perf_test_configs/disagg_8b_2p2d.yaml (3 hunks)
  • tests/planner/perf_test_configs/disagg_8b_3p1d.yaml (3 hunks)
  • tests/planner/perf_test_configs/disagg_8b_planner.yaml (4 hunks)
  • tests/planner/perf_test_configs/disagg_8b_tp2.yaml (3 hunks)
  • tests/planner/perf_test_configs/image_cache_daemonset.yaml (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants