fix: handle missing out_hidden_size for LLaVA models in EPD encode worker#6759
Conversation
Signed-off-by: Krishnan Prashanth <kprashanth@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
WalkthroughThis pull request adds defensive programming to safely access the vision model's hidden size attribute. The change implements a fallback chain that attempts to retrieve the hidden size from multiple sources, defaulting to "unknown" if unavailable, and logs the result for transparency. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…worker (#6759) Signed-off-by: Krishnan Prashanth <kprashanth@nvidia.com>
…worker (#6759) Signed-off-by: Krishnan Prashanth <kprashanth@nvidia.com>
…worker (ai-dynamo#6759) Signed-off-by: Krishnan Prashanth <kprashanth@nvidia.com>
Overview:
AttributeError: 'LlavaModel' object has no attribute 'out_hidden_size'crash inEncodeWorkerHandlerinitialization when using LLaVA models (e.g.,llava-hf/llava-1.5-7b-hf) in disaggregated EPD multimodal serving.getattrwith fallback tomodel.config.hidden_size, then"unknown"Fixes: DIS-1529
Summary by CodeRabbit