feat: add staged frontend gauges#8162
Conversation
WalkthroughThe PR introduces new Prometheus metrics for frontend pipeline instrumentation. It adds a Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
keivenchang
left a comment
There was a problem hiding this comment.
looks good — stage gauges are clean, tests cover the RAII lifecycle well. minor nits inline but nothing blocking.
|
@jh-nv The CI was stuck on this PR as there was an issue on main. It is now resolved. To get the fix please pull main and resolve conflicts. |
Overview:
Phase one of #8054 implementation. adding new gauges with clear stage boundary that are continuous without overlap.
Details:
entry to response complete) with a clearer name, emitted alongside the existing gauge
preprocess, route, and dispatch stages, with phase label (prefill/decode/aggregated) for
disaggregated mode visibility
instrumentation point
InflightGuard
Test plan
active_requests=3 observed in-flight, all return to 0 after completion
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Summary by CodeRabbit
Release Notes
New Features
Refactor