docs(mocker): clarify mocker image placeholder#8274
Merged
Conversation
…-runtime The image reference `my-registry/mocker-runtime:my-tag` in the mocker deploy YAMLs implies an image that does not exist on NGC (see DGH-719 / GH #7860 — users hit a 401 trying to pull `nvcr.io/nvidia/ai-dynamo/mocker-runtime:1.0.1`). The mocker component (`python3 -m dynamo.mocker`) is actually bundled into the standard Dynamo backend runtime images (vllm-runtime, sglang-runtime, tensorrtllm-runtime). Change the placeholder to `my-registry/vllm-runtime:my-tag` (matches the default engine-type for mocker) and add a header comment pointing users to the NGC Dynamo runtime images.
Per review, swap the `my-registry/vllm-runtime:my-tag` placeholder for a vendor/engine-neutral `my-dynamo-image:my-tag` so the YAMLs don't bias users toward any one backend runtime. The header NOTE still points at the NGC vllm/sglang/tensorrtllm runtime images.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughUpdated Kubernetes deployment manifests in the mocker backend examples to replace container image references from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
/ok to test 54cc857 |
tmonty12
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview:
The image reference
my-registry/mocker-runtime:my-tagin the mocker deploy YAMLs implies an image that does not exist on NGC (see DGH-719 / GH #7860 — users hit a 401 trying to pullnvcr.io/nvidia/ai-dynamo/mocker-runtime:1.0.1). The mocker component (python3 -m dynamo.mocker) is actually bundled into the standard Dynamo backend runtime images (vllm-runtime, sglang-runtime, tensorrtllm-runtime).Change the placeholder to
my-registry/vllm-runtime:my-tag(matches the default engine-type for mocker) and add a header comment pointing users to the NGC Dynamo runtime images.Details:
Where should the reviewer start?
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Closes #7860
Summary by CodeRabbit
Documentation
Chores