Skip to content

chore: upgrade modelexpress version#8336

Merged
pvijayakrish merged 6 commits into
mainfrom
nmailhot/mx-030-upgrade
Apr 21, 2026
Merged

chore: upgrade modelexpress version#8336
pvijayakrish merged 6 commits into
mainfrom
nmailhot/mx-030-upgrade

Conversation

@nv-nmailhot
Copy link
Copy Markdown
Contributor

@nv-nmailhot nv-nmailhot commented Apr 18, 2026

Overview:

Details:

Where should the reviewer start?

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

Summary by CodeRabbit

  • Chores
    • Updated internal dependencies and configuration components to maintain compatibility.

@nv-nmailhot nv-nmailhot requested review from a team as code owners April 18, 2026 00:29
@nv-nmailhot nv-nmailhot changed the title Chore: upgrade modelexpress version chore: upgrade modelexpress version Apr 18, 2026
@github-actions github-actions Bot added the chore label Apr 18, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 18, 2026

Walkthrough

This PR updates ModelExpress dependencies and configuration. Cargo.toml dependency versions are bumped from 0.2.0 to 0.3.0, and the ModelExpress reference commit hash in the vLLM configuration is updated to a newer revision.

Changes

Cohort / File(s) Summary
ModelExpress Updates
Cargo.toml, container/context.yaml
Dependency version bumps for modelexpress-client and modelexpress-common from 0.2.0 to 0.3.0, and vLLM configuration update of modelexpress_ref hash to a newer commit.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description contains only placeholder template text with no actual details about the changes, upgrade rationale, or testing. Fill in the Overview, Details, and Where should the reviewer start sections with specific information about the 0.2.0 to 0.3.0 upgrade, changes to Cargo.toml and container/context.yaml, and any testing or validation performed.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title accurately describes the main change: upgrading ModelExpress dependencies from 0.2.0 to 0.3.0 and updating the ModelExpress reference in the container configuration.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Comment thread container/context.yaml Outdated
Co-authored-by: Dmitry Tokarev <dtokarev@nvidia.com>
Signed-off-by: Nate Mailhot <nmailhot@nvidia.com>
Comment thread container/context.yaml
enable_kvbm: "true"
enable_modelexpress_p2p: "false"
modelexpress_ref: "3d73992ce6c10e52ddc54f7f12af35d27e173f15"
modelexpress_ref: "76fc5d7f06c37121ee8789a29fac6f9b08c4743a" # v0.3.0
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add this ref to the sglang and trtllm containers too? Or is that handled by the cargo.toml?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cargo.toml handles

@nv-nmailhot nv-nmailhot enabled auto-merge (squash) April 20, 2026 23:42
@nv-nmailhot nv-nmailhot disabled auto-merge April 20, 2026 23:43
@pvijayakrish pvijayakrish merged commit 9514236 into main Apr 21, 2026
94 of 96 checks passed
@pvijayakrish pvijayakrish deleted the nmailhot/mx-030-upgrade branch April 21, 2026 19:51
nv-nmailhot added a commit that referenced this pull request Apr 21, 2026
Signed-off-by: Nate Mailhot <nmailhot@nvidia.com>
Co-authored-by: Dmitry Tokarev <dtokarev@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants