Skip to content

docs: add --prerelease=allow to sglang install commands#8358

Merged
KrishnanPrash merged 2 commits into
mainfrom
kprashanth/dyn-2727
Apr 20, 2026
Merged

docs: add --prerelease=allow to sglang install commands#8358
KrishnanPrash merged 2 commits into
mainfrom
kprashanth/dyn-2727

Conversation

@KrishnanPrash
Copy link
Copy Markdown
Contributor

@KrishnanPrash KrishnanPrash commented Apr 20, 2026

Overview:

sglang 0.5.10.post1 (pinned by ai-dynamo 1.1.0) depends on flash-attn-4>=4.0.0b4 which has no stable release. pip/uv refuse transitive pre-releases by default, so plain pip install ai-dynamo[sglang] will fail once 1.1.0 publishes to PyPI.

Add --prerelease=allow (uv) to the three sglang install commands that were missing it. Switch the README from pip to uv to avoid a silent PIP_CONSTRAINT backtrack issue in NGC pytorch containers.

Details:

  • Add --prerelease=allow to 3 sglang pip-install commands missing it (README.md, docs/backends/sglang/README.md, docs/reference/release-artifacts.md)
  • Switch README from pip to uv pip install to match project convention and avoid silent PIP_CONSTRAINT backtrack in NGC pytorch containers
  • Add inline uv install hint to README

Resolves: DYN-2727


Open in Devin Review

Summary by CodeRabbit

  • Documentation
    • Updated installation instructions across multiple sections to enable pre-release package versions
    • Updated package manager guidance to use uv for dependency installation

Signed-off-by: Krishnan Prashanth <kprashanth@nvidia.com>
@github-actions github-actions Bot added fix documentation Improvements or additions to documentation labels Apr 20, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 potential issues.

Open in Devin Review

Comment thread README.md Outdated
Comment thread docs/reference/release-artifacts.md
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 20, 2026

Walkthrough

Three documentation files updated to add the --prerelease=allow flag to uv pip install commands for installing ai-dynamo with specific backends. The main README also adds an explicit uv setup instruction before dependency installation.

Changes

Cohort / File(s) Summary
Installation Documentation Updates
README.md, docs/backends/sglang/README.md, docs/reference/release-artifacts.md
Updated uv pip install commands to include --prerelease=allow flag for ai-dynamo package installation. Main README also adds explicit uv setup step prior to dependency installation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The description covers all required template sections with complete context, explaining the problem, specific changes made, and issue resolution.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title accurately summarizes the main change: adding --prerelease=allow flag to sglang installation commands across documentation files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@README.md`:
- Line 128: Update the inline install suggestion in README where the command
shows uv pip install --prerelease=allow "ai-dynamo[sglang]"   # or [vllm] or
[trtllm] to avoid misleading users about TRT-LLM; either remove the “[trtllm]”
token from that inline comment or replace it with a brief parenthetical like
“(TRT-LLM requires a different pip command with --extra-index-url
https://pypi.nvidia.com as described in the backend-specific notes)” so readers
skimming the README won’t try the uv pip shortcut for trtllm; edit the exact
line containing the bracketed backend list in README.md.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7470d27a-dce4-4ba2-a6ea-2e92af842ab4

📥 Commits

Reviewing files that changed from the base of the PR and between 714b423 and 4691939.

📒 Files selected for processing (3)
  • README.md
  • docs/backends/sglang/README.md
  • docs/reference/release-artifacts.md

Comment thread README.md Outdated
Signed-off-by: Krishnan Prashanth <kprashanth@nvidia.com>
@KrishnanPrash KrishnanPrash changed the title fix(docs): add --prerelease=allow to sglang install commands docs: add --prerelease=allow to sglang install commands Apr 20, 2026
@github-actions github-actions Bot added docs and removed fix labels Apr 20, 2026
@KrishnanPrash KrishnanPrash merged commit 9054c88 into main Apr 20, 2026
65 checks passed
@KrishnanPrash KrishnanPrash deleted the kprashanth/dyn-2727 branch April 20, 2026 18:23
nv-nmailhot pushed a commit that referenced this pull request Apr 20, 2026
Signed-off-by: Krishnan Prashanth <kprashanth@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs documentation Improvements or additions to documentation size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants