docs: add --prerelease=allow to sglang install commands#8358
Conversation
Signed-off-by: Krishnan Prashanth <kprashanth@nvidia.com>
WalkthroughThree documentation files updated to add the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@README.md`:
- Line 128: Update the inline install suggestion in README where the command
shows uv pip install --prerelease=allow "ai-dynamo[sglang]" # or [vllm] or
[trtllm] to avoid misleading users about TRT-LLM; either remove the “[trtllm]”
token from that inline comment or replace it with a brief parenthetical like
“(TRT-LLM requires a different pip command with --extra-index-url
https://pypi.nvidia.com as described in the backend-specific notes)” so readers
skimming the README won’t try the uv pip shortcut for trtllm; edit the exact
line containing the bracketed backend list in README.md.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 7470d27a-dce4-4ba2-a6ea-2e92af842ab4
📒 Files selected for processing (3)
README.mddocs/backends/sglang/README.mddocs/reference/release-artifacts.md
Signed-off-by: Krishnan Prashanth <kprashanth@nvidia.com>
Overview:
sglang 0.5.10.post1(pinned by ai-dynamo 1.1.0) depends onflash-attn-4>=4.0.0b4which has no stable release.pip/uvrefuse transitive pre-releases by default, so plainpip install ai-dynamo[sglang]will fail once 1.1.0 publishes to PyPI.Add --prerelease=allow (uv) to the three sglang install commands that were missing it. Switch the README from pip to uv to avoid a silent PIP_CONSTRAINT backtrack issue in NGC pytorch containers.
Details:
--prerelease=allowto 3 sglang pip-install commands missing it (README.md, docs/backends/sglang/README.md, docs/reference/release-artifacts.md)piptouv pip installto match project convention and avoid silentPIP_CONSTRAINTbacktrack in NGC pytorch containersuvinstall hint to READMEResolves: DYN-2727
Summary by CodeRabbit
uvfor dependency installation