Skip to content

docs(vllm-omni): note ARM64 not supported; flag GLM-Image as experimental#8373

Merged
ayushag-nv merged 1 commit into
mainfrom
ayushag/vllm-omni-arch-install
Apr 20, 2026
Merged

docs(vllm-omni): note ARM64 not supported; flag GLM-Image as experimental#8373
ayushag-nv merged 1 commit into
mainfrom
ayushag/vllm-omni-arch-install

Conversation

@ayushag-nv
Copy link
Copy Markdown
Contributor

@ayushag-nv ayushag-nv commented Apr 20, 2026

Overview:

Doc-only update to docs/backends/vllm/vllm-omni.md:

  • Note that vLLM-Omni is not currently installed on arm64 builds.
  • Flag zai-org/GLM-Image as experimental — generation may fail or produce incorrect outputs for some prompts/sizes.

No code changes.

Details:

  • Under ## Prerequisites → ### Installation, add an "ARM64 not supported" callout: the container build skips the vLLM-Omni install on arm64, so vLLM-Omni features are unavailable on that arch today.
  • Under ### Quick Start: GLM-Image (2-Stage, 2 GPUs), add an "Experimental" callout above the existing transformers>=5.0 known-issue note, warning that generation may fail or produce incorrect/garbled outputs for some prompts and sizes.

Where should the reviewer start?

  • docs/backends/vllm/vllm-omni.md — the only file changed. +4 lines.

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

@ayushag-nv ayushag-nv requested review from a team as code owners April 20, 2026 17:12
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Apr 20, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions Bot added chore backend::vllm Relates to the vllm backend container labels Apr 20, 2026
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@ayushag-nv
Copy link
Copy Markdown
Contributor Author

/ok to test 6e3eb78

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 20, 2026

Walkthrough

The vLLM-Omni installation gating logic was broadened to trigger whenever VLLM_OMNI_REF is non-empty, removing the prior requirement for ARCH=amd64. Status messages were updated to include architecture information, and the skip message was revised.

Changes

Cohort / File(s) Summary
vLLM Installation Gating
container/deps/vllm/install_vllm.sh
Relaxed installation condition from requiring both VLLM_OMNI_REF and ARCH=amd64 to only VLLM_OMNI_REF non-empty. Updated status messages to include arch=${ARCH} for PyPI success and source build fallback. Removed ARM64-not-supported skip message.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title mentions 'docs' and ARM64/GLM-Image documentation changes, but the raw summary shows code changes to install_vllm.sh script, not documentation-only changes. Update the title to accurately reflect the actual code changes (e.g., 'chore(container): broaden vLLM-Omni installation gating logic') or clarify if only docs were modified.
Description check ⚠️ Warning The PR description is incomplete and contradictory. It claims 'No code changes' but the raw summary shows 7 lines added/6 removed in vllm install script. Update the description to accurately reflect the actual code changes in container/deps/vllm/install_vllm.sh and clarify whether the PR modifies documentation, code, or both.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ayushag-nv ayushag-nv force-pushed the ayushag/vllm-omni-arch-install branch from 6e3eb78 to 9005a8d Compare April 20, 2026 18:49
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Apr 20, 2026
@ayushag-nv ayushag-nv changed the title chore(container): enable vLLM-Omni install on ARM64 docs(vllm-omni): note ARM64 not supported; flag GLM-Image as experimental Apr 20, 2026
@github-actions github-actions Bot added docs and removed chore labels Apr 20, 2026
@ayushag-nv
Copy link
Copy Markdown
Contributor Author

/ok to test 9005a8d

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 20, 2026

Comment thread docs/backends/vllm/vllm-omni.md
@ayushag-nv ayushag-nv enabled auto-merge (squash) April 20, 2026 19:02
Comment thread docs/backends/vllm/vllm-omni.md Outdated
Copy link
Copy Markdown
Contributor

@rmccorm4 rmccorm4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small notes

…ntal

Signed-off-by: ayushag <ayushag@nvidia.com>
@ayushag-nv ayushag-nv force-pushed the ayushag/vllm-omni-arch-install branch from 9005a8d to e5f8f45 Compare April 20, 2026 19:08
@ayushag-nv
Copy link
Copy Markdown
Contributor Author

/ok to test e5f8f45

@ayushag-nv ayushag-nv merged commit 8291bfc into main Apr 20, 2026
64 checks passed
@ayushag-nv ayushag-nv deleted the ayushag/vllm-omni-arch-install branch April 20, 2026 19:09
nv-nmailhot pushed a commit that referenced this pull request Apr 20, 2026
…ntal (cherry-pick of #8373) (#8394)

Signed-off-by: ayushag <ayushag@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend::vllm Relates to the vllm backend container docs documentation Improvements or additions to documentation size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants