Skip to content

docs(profiler): clarify when planner-profile-data ConfigMap is emitted [DYN-2751] (cherry-pick of #8486)#8516

Merged
nv-nmailhot merged 1 commit into
release/1.1.0from
hzhou/cp-8486
Apr 22, 2026
Merged

docs(profiler): clarify when planner-profile-data ConfigMap is emitted [DYN-2751] (cherry-pick of #8486)#8516
nv-nmailhot merged 1 commit into
release/1.1.0from
hzhou/cp-8486

Conversation

@tedzhouhk
Copy link
Copy Markdown
Contributor

@tedzhouhk tedzhouhk commented Apr 22, 2026

Summary

Cherry-pick of #8486 to release/1.1.0, with the docstring / TODO text adjusted for the release branch's actual behavior (rapid mode on release/1.1.0 still writes NPZ to disk — the main branch's AIC-in-planner deferral doesn't exist here yet).

Changes vs. the main PR:

  • Dropped the build_aic_interpolation_spec function addition entirely — it was introduced on main by feat(planner): own AIC interpolation; fix MoE-DEP bugs in rapid mode #8335 and has no home on release/1.1.0.
  • Dropped the "vLLM self-benchmark (DYN_BENCHMARK_MODE)" and "rapid mode defers to planner" language from the assemble_final_config docstring — neither exists on release/1.1.0.
  • Reworded the profile_sla.py TODO: on release, the gap is that run_interpolation skips agg picks entirely (no NPZ → no planner-profile-data-XXXX ConfigMap → planner/mocker have nothing to consume for agg deployments).

Net effect: documents the actual release/1.1.0 behavior observed in DYN-2751 and flags the agg + profiling-data gap with a TODO. No behavior change.

Test plan

  • pre-commit run on the two touched files passes.
  • Lint-only PR — no runtime change, no tests added.

Open in Devin Review

@tedzhouhk tedzhouhk requested review from a team as code owners April 22, 2026 16:44
@nv-nmailhot nv-nmailhot merged commit 6fb550c into release/1.1.0 Apr 22, 2026
66 of 67 checks passed
@nv-nmailhot nv-nmailhot deleted the hzhou/cp-8486 branch April 22, 2026 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants