docs(profiler): clarify when planner-profile-data ConfigMap is emitted [DYN-2751] (cherry-pick of #8486)#8516
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-pick of #8486 to
release/1.1.0, with the docstring / TODO text adjusted for the release branch's actual behavior (rapid mode on release/1.1.0 still writes NPZ to disk — the main branch's AIC-in-planner deferral doesn't exist here yet).Changes vs. the main PR:
build_aic_interpolation_specfunction addition entirely — it was introduced on main by feat(planner): own AIC interpolation; fix MoE-DEP bugs in rapid mode #8335 and has no home on release/1.1.0.DYN_BENCHMARK_MODE)" and "rapid mode defers to planner" language from theassemble_final_configdocstring — neither exists on release/1.1.0.profile_sla.pyTODO: on release, the gap is thatrun_interpolationskips agg picks entirely (no NPZ → noplanner-profile-data-XXXXConfigMap → planner/mocker have nothing to consume for agg deployments).Net effect: documents the actual release/1.1.0 behavior observed in DYN-2751 and flags the agg + profiling-data gap with a TODO. No behavior change.
Test plan
pre-commit runon the two touched files passes.