docs(parser): annotate every test with its CASE.* in TEST_CASES.md#8725
Conversation
WalkthroughA documentation file was extended with new test case categories (CASE.20–CASE.24) defining parser-internal detection scenarios and edge cases. Across multiple parser modules, unit test functions received inline case-identifying comments (e.g., Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ayushag-nv
left a comment
There was a problem hiding this comment.
@keivenchang Just one comment, do we need the TEST_CASES.md file in the repo. I won't prefer that. May be you can add it as a skill in .claude or something if you want to use it as testing skill ?
|
Thanks for doing this! |
Will address this in the next PR, we'll have skill (how to do something) and the md file (what corner cases we have) reference each other. Coming up! |
Cross-index every existing inline parser test with the universal test-case taxonomy in lib/parsers/TEST_CASES.md (renamed from TESTING.md) so a single `grep CASE.5` finds every missing-end-token test across every parser. No code changes — only `//` line comments next to existing #[test] attributes plus edits to lib/parsers/TEST_CASES.md. All 389 existing tests pass unmodified. Signed-off-by: Keiven Chang <keivenchang@users.noreply.github.com>
5c5bb7b to
742405d
Compare
…8725) Signed-off-by: Keiven Chang <keivenchang@users.noreply.github.com>
hey guys, I'm just doing a trivial (NO CODE CHANGE) doc reorg so the docs read more clearly and the tests are categorized so we have an idea of coverage. all 389 tests still pass.
paired with DIS-1842's contract test scaffold (#8728) — that PR adds runnable cross-parser tests, this one makes existing per-parser tests greppable.