fix(test): add missing pytest markers to video/audio protocol tests#8849
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
WalkthroughThree test modules in the dynamo/common/tests directory now declare a module-level Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
keivenchang
approved these changes
Apr 29, 2026
furionw
approved these changes
Apr 29, 2026
…io is installed Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
grahamking
approved these changes
Apr 29, 2026
dmitry-tokarev-nv
approved these changes
Apr 29, 2026
This was referenced Apr 29, 2026
furionw
pushed a commit
that referenced
this pull request
May 2, 2026
…8849) Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The video streaming PR (#8491) added 3 test files to
components/src/right after the marker enforcement PR (#7796) expanded the pre-commit check to that directory. Since the new tests didn't include the required markers, every PR's pre-commit hook started failing — 49 tests flagged as missing Lifecycle, Test Type, and Hardware markers.This adds the standard
pytestmarkblock to those 3 files so pre-commit passes again.Repro:
Details
The marker enforcement hook (
pytest-marker-report) requires every test to carry at least one marker from each of three categories: Lifecycle (pre_merge,post_merge, etc.), Test Type (unit,integration, etc.), and Hardware (gpu_0,gpu_1, etc.).The video streaming PR landed ~40 minutes after the enforcement expansion, and its tests didn't have any markers. Since the hook scans all files (not just changed ones), this broke pre-commit for every subsequent PR.
Files fixed:
components/src/dynamo/common/tests/test_audio_protocol.pycomponents/src/dynamo/common/tests/test_video_protocol.pycomponents/src/dynamo/common/tests/test_video_utils.pyAll three are pure pydantic/protocol validation tests — no GPU, no external services — so
unit,gpu_0,pre_mergeis the right fit, matching adjacent files in the same directory.Where should the reviewer start?
Any of the 3 files — the change is identical in each: a
pytestmarklist after the imports.Test Plan
python3 tests/report_pytest_markers.pyon main →Missing sets: 49Missing sets: 0Missing sets: 0— confirms the video streaming PR is the sourceMissing sets: 49— confirms root causeRelated Issues
🤖 Generated with Claude Code
Summary by CodeRabbit