refactor: [kvbm][cleanup] Remove unused same-layout disjoint validation

[oandreeva-nv]

The are_same_layout helper triggered a dead_code warning in release builds because its only caller, validate_disjoint_same_layout, was gated behind #[cfg(debug_assertions)]. Removing the unused validation path along with its error variant and tests rather than silencing with a cfg gate.

Overview:

Details:

Where should the reviewer start?

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

• closes GitHub issue: #xxx

---

[coderabbitai]

Walkthrough

Removed the OverlappingBlocks error variant from BlockValidationError, deleted the debug-only validate_disjoint_same_layout function and its layout-comparison helper, and removed the corresponding validation call from validate_block_transfer. Block transfer validation no longer checks for same-layout source/destination overlap in debug builds.

Changes

Overlapping blocks validation removal

Layer / File(s)	Summary
Remove overlapping blocks validation logic lib/llm/src/block_manager/v2/physical/transfer/validation.rs	BlockValidationError enum no longer includes the OverlappingBlocks variant; the debug-only validate_disjoint_same_layout function and its layout-pointer comparison helper are deleted; and the validation call within validate_block_transfer is removed.

---

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	The PR description provides context about the dead_code warning and the rationale for removal, but lacks specific details about files affected and reviewer guidance.	Enhance the description by filling in the template sections: specify which files changed, what the removed validation checked for, and confirm there are no other usages of the removed code.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: removing the unused same-layout disjoint validation code path.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

• Generate code and open pull requests
• Plan features and break down work
• Investigate incidents and troubleshoot customer tickets together
• Automate recurring tasks and respond to alerts with triggers
• Summarize progress and report instantly

Built for teams:

• Shared memory across your entire org—no repeating context
• Per-thread sandboxes to safely plan and execute work
• Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[dynamo-ops]

lib/llm/src/block_manager/v2/physical/transfer/validation.rs — Removing the public OverlappingBlocks variant from the re-exported BlockValidationError enum breaks downstream exhaustive matches or constructors even if the validation path was unused. Fix: restore the variant as deprecated and leave it unconstructed until the next breaking API cleanup.