The ruler width can become out of sync with the canvas size#410
Open
mr83-uw wants to merge 1 commit intoaidenlab:masterfrom
Open
The ruler width can become out of sync with the canvas size#410mr83-uw wants to merge 1 commit intoaidenlab:masterfrom
mr83-uw wants to merge 1 commit intoaidenlab:masterfrom
Conversation
…fore redrawing the ruler.
Author
The juicebox.js client will draw the ruler correctly on the first pass, but when zooming in, it draws outside the bounds of the parent container. This fix will check the offset width of the axis element, and sync it with the ruler canvas. |
Collaborator
|
@mr83-uw can you provide a session file so that I can try to reproduce the bug? Thx. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check before redrawing the ruler.