Conversation
|
@pivanov is attempting to deploy a commit to the Million Team on Vercel. A member of the Team first needs to authorize it. |
commit: |
lxsmnsyc
reviewed
Feb 5, 2025
| const refContainer = useRef<HTMLDivElement>(null); | ||
|
|
||
| useEffect(() => { | ||
| const unsubscribeStoreInspectState = Store.inspectState.subscribe( |
Collaborator
There was a problem hiding this comment.
We could perhaps use useSignalEffect, just to simplfy stuff (One thing I learned during the rewrite)
Collaborator
There was a problem hiding this comment.
oh cool, does it automatically track dependencies?
Collaborator
Author
There was a problem hiding this comment.
yeah we can I just try to do it one way because of the perf optimisations it's easy to find all subscriptions and refactor them at once :) we have places with few subscriptions and I just don't wanna mess up diff implementations ... but you are absolutely right!!! :)
pivanov
added a commit
to pivanov/react-scan
that referenced
this pull request
Feb 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.