Conversation
Adds a shortcuts entry to the manifest so long-pressing the installed PWA icon on Android shows a "Quick Note" action that opens /?quick=1. https://claude.ai/code/session_01AeDjZauHMpEX5VsNM2bRYz
Greptile SummaryThis PR adds a Confidence Score: 5/5Safe to merge — minimal, focused config change with no runtime logic impact. The only finding is a P2 edge-case where a mis-configured (trailing-slash-free) No files require special attention. Important Files Changed
Sequence DiagramsequenceDiagram
participant User as Android User
participant OS as Android OS
participant Manifest as PWA Manifest
participant App as PedalNotes SPA
User->>OS: Long-press app icon
OS->>Manifest: Read shortcuts[]
Manifest-->>OS: "Quick Note" → /?quick=1
User->>OS: Tap "Quick Note"
OS->>App: Open /?quick=1
App->>App: useMemo → isQuickMode = true
App-->>User: Render quick-note UI
Reviews (1): Last reviewed commit: "Add Quick Note PWA app shortcut" | Re-trigger Greptile |
| name: "Quick Note", | ||
| short_name: "Quick Note", | ||
| description: "Log a quick workout note with RPE and feel", | ||
| url: `${basePath}?quick=1`, |
There was a problem hiding this comment.
URL may be malformed when
VITE_BASE_PATH lacks a trailing slash
If VITE_BASE_PATH is set to a sub-path without a trailing slash (e.g. /pedalnotes), the template literal produces /pedalnotes?quick=1 — the query string is appended directly to the base path rather than to the root index (/pedalnotes/?quick=1). Vite expects base to end with /, but it is worth making this construction resilient so the shortcut URL always targets the app's index page.
| url: `${basePath}?quick=1`, | |
| url: `${basePath.replace(/\/?$/, '/')}?quick=1`, |
Adds a shortcuts entry to the manifest so long-pressing the installed
PWA icon on Android shows a "Quick Note" action that opens /?quick=1.
https://claude.ai/code/session_01AeDjZauHMpEX5VsNM2bRYz