Merged
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
GabrieleMeoni
requested changes
Feb 2, 2023
Collaborator
GabrieleMeoni
left a comment
There was a problem hiding this comment.
It works for me. Notice that I first tried to install mpi4py by using pip on Windows. It led to DLL errors, so I had to reinstall it by using conda. Now it works.
examples/MPI_example/mpi_example.py
Outdated
| line of sight of each other. For simplicity, the modelled task here will be to count the number of | ||
| window encounters for each satellite. | ||
|
|
||
| N.B. There are some simplifications in this example. Running this on a larger scale |
Collaborator
There was a problem hiding this comment.
It is not really clear what you mean here. I would rephrase it.
examples/MPI_example/mpi_example.py
Outdated
| # Synchronize between and print some stats. | ||
| comm.Barrier() | ||
| end = time.time() | ||
| sys.stdout.flush() |
Collaborator
There was a problem hiding this comment.
Can you comment what is used for?
Co-authored-by: Gabriele Meoni <70584239+GabrieleMeoni@users.noreply.github.com>
GabrieleMeoni
approved these changes
Feb 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary of changes
Resolved Issues
How Has This Been Tested?
Running the script
Related Pull Requests
N/A