Merged
Conversation
gomezzz
requested changes
Feb 15, 2023
Collaborator
gomezzz
left a comment
There was a problem hiding this comment.
Some minor changes and one problem: tests fail for me with
FAILED paseos/tests/operations_monitor_test.py::test_monitor - PermissionError: [Errno 13] Permission denied: 'test.csv'
FAILED paseos/tests/thermal_model_test.py::test_thermal - PermissionError: [Errno 13] Permission denied: 'thermal_test.csv'
FAILED paseos/tests/visualization_test.py::test_animation - RuntimeError: x must be a sequence
Detailed logs below
Error in test_animation:
def test_animation():
"""Simple test to verify that the animation executes without errors."""
sim, sat1, earth = get_default_instance()
sat2 = ActorBuilder.get_actor_scaffold("sat2", SpacecraftActor, pk.epoch(0))
ActorBuilder.set_orbit(sat2, [0, 10000000, 0], [0, 0, 8000.0], pk.epoch(0), earth)
ActorBuilder.set_power_devices(sat2, 5000, 10000, 1)
sim.add_known_actor(sat2)
anim = SpaceAnimation(sim)
dt = 100
for t in range(10):
> anim.animate(sim, dt)
paseos/tests/visualization_test.py:24:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ paseos/visualization/space_animation.py:413: in animate
self._animate(sim, dt)
paseos/visualization/space_animation.py:385: in _animate
self.update(sim, creating_animation=True)
paseos/visualization/space_animation.py:325: in update
self._plot_actors()
paseos/visualization/space_animation.py:210: in _plot_actors
obj.plot.point.set_data_3d(data[-1, :])
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
self = <mpl_toolkits.mplot3d.art3d.Line3D object at 0x7f95f5eb6550>, args = array([1.56476773, 0.12534795, 0. ]), name = 'x', xyz = 1.564767732458861
def set_data_3d(self, *args):
"""
Set the x, y and z data
Parameters
----------
x : array-like
The x-data to be plotted.
y : array-like
The y-data to be plotted.
z : array-like
The z-data to be plotted.
Notes
-----
Accepts x, y, z arguments or a single array-like (x, y, z)
"""
if len(args) == 1:
args = args[0]
for name, xyz in zip('xyz', args):
if not np.iterable(xyz):
> raise RuntimeError(f'{name} must be a sequence')
E RuntimeError: x must be a sequence
../conda/envs/paseos/lib/python3.11/site-packages/mpl_toolkits/mplot3d/art3d.py:246: RuntimeError
test_thermal
paseos/tests/thermal_model_test.py:59:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ paseos/paseos.py:77: in save_status_log_csv
self._operations_monitor.save_to_csv(filename)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
self = <paseos.utils.operations_monitor.OperationsMonitor object at 0x7f95f4dada50>, filename = 'thermal_test.csv'
def save_to_csv(self, filename):
"""Write the created log file to a csv file.
Args:
filename (str): File to store the log in.
"""
logger.trace("Writing status log file to " + filename)
> with open(filename, "w", newline="") as f:
E PermissionError: [Errno 13] Permission denied: 'thermal_test.csv'
paseos/utils/operations_monitor.py:98: PermissionError
test_monitor
> sim.save_status_log_csv("test.csv")
paseos/tests/operations_monitor_test.py:59:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ paseos/paseos.py:77: in save_status_log_csv
self._operations_monitor.save_to_csv(filename)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
self = <paseos.utils.operations_monitor.OperationsMonitor object at 0x7f95f5ef4e10>, filename = 'test.csv'
def save_to_csv(self, filename):
"""Write the created log file to a csv file.
Args:
filename (str): File to store the log in.
"""
logger.trace("Writing status log file to " + filename)
> with open(filename, "w", newline="") as f:
E PermissionError: [Errno 13] Permission denied: 'test.csv'
paseos/utils/operations_monitor.py:98: PermissionError
Collaborator
|
An, one more thing, we should add links to the containers to the README with short explanation, I think? (somewhere in installation, I guess?) |
Closed
Update README.
Create docker-nightly-image.yml
gomezzz
requested changes
Feb 17, 2023
Collaborator
gomezzz
left a comment
There was a problem hiding this comment.
Some comments still open
Co-authored-by: Pablo Gómez <contact@pablo-gomez.net>
Co-authored-by: Pablo Gómez <contact@pablo-gomez.net>
gomezzz
approved these changes
Feb 20, 2023
Collaborator
|
@GabrieleMeoni can you merge main to check CI passes now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Summary of changes