Increased allowed ranges for tests to allow passing tests on slower devices#158
Merged
Increased allowed ranges for tests to allow passing tests on slower devices#158
Conversation
GabrieleMeoni
approved these changes
Mar 2, 2023
Collaborator
GabrieleMeoni
left a comment
GabrieleMeoni
left a comment
There was a problem hiding this comment.
I approve it. Can you, just, clarify how did you set the new values?
Collaborator
Author
Basically the CI in the link issue took longer to complete the test which drew more power. So I made the tests pass even if it takes longer (and made the speedup a bit smaller). Might be it is still not enough, we will see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Increased allow test ranges
Resolved Issues
How Has This Been Tested?
Ran CI locally and on github
Related Pull Requests
N/A