Conversation
GabrieleMeoni
requested changes
Jun 19, 2023
Collaborator
GabrieleMeoni
left a comment
There was a problem hiding this comment.
All good for me except one very minor request. I tested it, and it seems working.
About flake I would leave 127 chars, otherwise it becomes very annoying.
Co-authored-by: Gabriele Meoni <70584239+GabrieleMeoni@users.noreply.github.com>
Collaborator
Author
But then we should reformat because before we agreed on 100 and most of the repo is in 100 but now some parts are 127. So you will have a lot of formatting changes either ways because it is now inconsistent. I would suggest to create an issue to either:
|
GabrieleMeoni
requested changes
Jun 22, 2023
GabrieleMeoni
approved these changes
Jun 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary of changes
Resolved Issues
N/A
How Has This Been Tested?
CI/CD, new test
Related Pull Requests
N/A