Skip to content

Minor fixes#170

Merged
gomezzz merged 2 commits intomainfrom
small-fixes
Jul 6, 2023
Merged

Minor fixes#170
gomezzz merged 2 commits intomainfrom
small-fixes

Conversation

@gomezzz
Copy link
Collaborator

@gomezzz gomezzz commented Jun 26, 2023

Description

Two minor fixes.

  • Changed custom quantity creation to info instead of warning
  • Fixed altitude being a property

Resolved Issues

N/A

How Has This Been Tested?

CI/CD

Related Pull Requests

N/A

- Changed custom quantity to info instead of warning
@gomezzz gomezzz added the bug Something isn't working label Jun 26, 2023
@github-actions
Copy link

github-actions bot commented Jun 26, 2023

Overall Coverage

Coverage Report
FileStmtsMissCoverMissing
paseos
   __init__.py31294%46, 49
   paseos.py1511491%71–72, 144–145, 198, 213, 231, 240, 258, 289, 297–298, 398–399
paseos/activities
   activity_manager.py43393%46, 76, 159
   activity_processor.py58198%123
   activity_runner.py621084%80–84, 104–113, 122–125
paseos/actors
   actor_builder.py1082181%20–24, 27, 119–124, 248, 296, 318, 328–332, 339–340, 345–346
   base_actor.py1201885%82, 99, 115, 153, 193–195, 224, 233, 250, 273, 279–282, 286, 300, 348
   ground_station_actor.py15380%47–53
   spacecraft_actor.py61198%123
paseos/communication
   get_communication_window.py22291%38, 67
   is_in_line_of_sight.py741580%75, 82, 90, 152–169, 213, 233
paseos/power
   charge_model.py17194%54
   discharge_model.py7271%22, 34
   is_in_eclipse.py39490%28–29, 90–91
paseos/tests
   activity_test.py57395%92, 95–96
   communication_window_test.py58198%198
   eclipse_test.py11191%22
   import_test.py6183%13
   init_test.py8188%16
   line_of_sight_test.py65494%147–150
   thermal_model_test.py30197%63
   visualization_test.py20195%31
paseos/utils
   check_cfg.py611870%31, 40, 46, 62–64, 71, 74–76, 79–81, 84–86, 101, 106
   operations_monitor.py71494%86, 127–130
paseos/visualization
   animation.py18667%27–30, 35, 44
   plot.py9367%28–31
   space_animation.py1952090%135, 159, 162–165, 171, 283, 308–310, 315, 325–326, 330, 365, 371–372, 405, 421–432
TOTAL183016191% 

Tests Skipped Failures Errors Time
30 0 💤 0 ❌ 0 🔥 1m 3s ⏱️

pass

@property
def altitude(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you call it get_altitude(...) to be consistent (e.g., get_position())?

@gomezzz gomezzz requested a review from GabrieleMeoni June 27, 2023 09:57
@gomezzz gomezzz merged commit 1539d3a into main Jul 6, 2023
@gomezzz gomezzz deleted the small-fixes branch July 6, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants