Merged
Conversation
…now in my own fork instead of Moana's)
…erence frame transformation function
…unction to form this transformation matrix)
…of floats, outputs: numpy arrays (needs to be reviewed in implementation)
…l and magnetic) on actor. started with set_attitude_model and attitude model class as well.
…access the I-matrix)
deleted redundant function (which I added myself)
pointing vector function
Co-authored-by: Gabriele Meoni <70584239+GabrieleMeoni@users.noreply.github.com>
Co-authored-by: Gabriele Meoni <70584239+GabrieleMeoni@users.noreply.github.com>
Co-authored-by: Gabriele Meoni <70584239+GabrieleMeoni@users.noreply.github.com>
…and one ensuring the attitude and thermal models don't break each other
GabrieleMeoni
requested changes
Jan 29, 2024
Collaborator
GabrieleMeoni
left a comment
GabrieleMeoni
left a comment
There was a problem hiding this comment.
Very small requests for clarification. The rest is all good.
paseos/tests/attitude_test.py
Outdated
| actor_initial_angular_velocity=[0.0, 2 * np.pi / orbit_period, 0.0], | ||
| actor_pointing_vector_body=[0, 0, 1], | ||
| ) | ||
| ActorBuilder.set_disturbances(sat1) |
Collaborator
There was a problem hiding this comment.
Did you check with the others what is supposed to happen when all disturbances are set?
Collaborator
Author
There was a problem hiding this comment.
We will add seperate disturbance tests in this file for every disturbance. This line could be deleted.
GabrieleMeoni
approved these changes
Jan 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Similar to pull request #194 .
Attitude model with outputs: actor attitude (roll, pitch & yaw angles) and user specified pointing vector. Now also outputs actor angular velocity vector and uses the actor moment of inertia from geometrical model from #195.
Attitude disturbances will be added in a later PR.
Resolved Issues
How Has This Been Tested?
Refer to "test_attitude_plotting.py" for visual reference of attitude model and response to changes of actor initial conditions.
Summary of changes.
More elaborate tests will follow.
Related Pull Requests