Added the tests for the geometric_model#199
Merged
GabrieleMeoni merged 5 commits intostudentfrom Jan 23, 2024
Merged
Conversation
Collaborator
GabrieleMeoni
left a comment
There was a problem hiding this comment.
Do we need the @Property decorator at line 81 in geometric_model? I just noticed itreviewing your code. P There is no setter or deleter, so it looks weird to me. Please remove it and doublecheck. Let me know. For the rest, it looks good.
GabrieleMeoni
approved these changes
Jan 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary of changes
Resolved Issues
Related Pull Requests